feat: Update RUF055 to do var == value - #15605
Merged
Merged
Conversation
This commit fixes RUF055 rule to format re.fullmatch(pattern, var) to var == pattern instead of current pattern == var behaviour. This is more idiomatic and easy to understand.
Contributor
|
Member
|
@ntBre would you mind reviewing this one? |
ntBre
requested changes
Jan 20, 2025
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
This looks great, thanks for fixing this! I had a couple of small suggestions, but otherwise this looks good to me.
ntBre
approved these changes
Jan 21, 2025
ntBre
left a comment
ntBre
left a comment
Contributor
There was a problem hiding this comment.
This looks great, thank you again!
dcreager
added a commit
that referenced
this pull request
Jan 21, 2025
* main: Separate grouped and ungrouped nodes more clearly in AST generator (#15646) [`flake8-simplify`] Mark fixes as unsafe (`SIM201`, `SIM202`) (#15626) [red-knot] mdtest runner: include stderr for crashing tests (#15644) Change `EnvironmentOptions::venv-path` to `Option<SystemPathBuf>` (#15631) [`flake8-type-checking`] Fix some safe fixes being labeled unsafe (#15638) feat: Update RUF055 to do var == value (#15605)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes RUF055 rule to format
re.fullmatch(pattern, var)tovar == patterninstead of the currentpattern == varbehaviour. This is more idiomatic and easy to understand.Summary
This changes the current formatting behaviour of
re.fullmatch(pattern, var)to format it tovar == patterninstead ofpattern == var.Test Plan
I used a code file locally to see the updated formatting behaviour.
Fixes #14733