-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not put sources+types into NpmPackageStoreInfo.files #1850
Merged
jbedard
merged 3 commits into
aspect-build:main
from
jbedard:js_library-trim-store-info-except-links
Jul 25, 2024
Merged
fix: do not put sources+types into NpmPackageStoreInfo.files #1850
jbedard
merged 3 commits into
aspect-build:main
from
jbedard:js_library-trim-store-info-except-links
Jul 25, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
js_library-trim-store-info-except-links
branch
from
July 18, 2024 18:05
8391337
to
01ce326
Compare
jbedard
commented
Jul 18, 2024
jbedard
force-pushed
the
js_library-trim-store-info-except-links
branch
2 times, most recently
from
July 18, 2024 18:29
0205758
to
5664ebc
Compare
jbedard
commented
Jul 18, 2024
jbedard
force-pushed
the
js_library-trim-store-info-except-links
branch
from
July 18, 2024 19:13
5664ebc
to
7f3c785
Compare
This was referenced Jul 18, 2024
jbedard
commented
Jul 18, 2024
jbedard
force-pushed
the
js_library-trim-store-info-except-links
branch
from
July 20, 2024 01:22
7f3c785
to
c8ce28c
Compare
jbedard
force-pushed
the
js_library-trim-store-info-except-links
branch
from
July 24, 2024 21:31
c8ce28c
to
1f2cdf8
Compare
jbedard
commented
Jul 24, 2024
jbedard
commented
Jul 24, 2024
gregmagolan
force-pushed
the
js_library-trim-store-info-except-links
branch
from
July 25, 2024 15:36
85798f2
to
ed71f4c
Compare
gregmagolan
approved these changes
Jul 25, 2024
This was referenced Sep 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
NpmPackageStoreInfo
files
andtransitive_files
now only contain the files/symlinks required to put the package into the store. All sources + types are only in theJsInfo
which was already passed around throughout these targets but now must be read in addition to theNpmPackageStoreInfo
.Close #1847
Changes are visible to end-users: no
Test plan