Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not put sources+types into NpmPackageStoreInfo.files #1850

Merged

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Jul 18, 2024

The NpmPackageStoreInfo files and transitive_files now only contain the files/symlinks required to put the package into the store. All sources + types are only in the JsInfo which was already passed around throughout these targets but now must be read in addition to the NpmPackageStoreInfo.

Close #1847


Changes are visible to end-users: no

Test plan

Copy link

aspect-workflows bot commented Jul 18, 2024

Test

All tests were cache hits

195 tests (100.0%) were fully cached saving 37s.


Test

e2e/bzlmod

All tests were cache hits

4 tests (100.0%) were fully cached saving 459ms.


Test

e2e/gyp_no_install_script

All tests were cache hits

2 tests (100.0%) were fully cached saving 534ms.


Test

e2e/js_image_oci

All tests were cache hits

1 test (100.0%) was fully cached saving 7s.


Test

e2e/npm_link_package

All tests were cache hits

2 tests (100.0%) were fully cached saving 583ms.


Test

e2e/npm_link_package-esm

All tests were cache hits

2 tests (100.0%) were fully cached saving 1s.


Test

e2e/npm_translate_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_empty

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_lock_multi

All tests were cache hits

2 tests (100.0%) were fully cached saving 271ms.


Test

e2e/npm_translate_lock_partial_clone

All tests were cache hits

1 test (100.0%) was fully cached saving 117ms.


Test

e2e/npm_translate_lock_subdir_patch

All tests were cache hits

1 test (100.0%) was fully cached saving 269ms.


Test

e2e/npm_translate_package_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/npm_translate_yarn_lock

All tests were cache hits

1 test (100.0%) was fully cached saving 73ms.


Test

e2e/package_json_module

All tests were cache hits

1 test (100.0%) was fully cached saving 574ms.


Test

e2e/pnpm_lockfiles

All tests were cache hits

28 tests (100.0%) were fully cached saving 13s.


Test

e2e/pnpm_workspace

All tests were cache hits

10 tests (100.0%) were fully cached saving 6s.


Test

e2e/pnpm_workspace_rerooted

All tests were cache hits

10 tests (100.0%) were fully cached saving 6s.


Test

e2e/repo_mapping

All tests were cache hits

2 tests (100.0%) were fully cached saving 464ms.


Test

e2e/rules_foo

All tests were cache hits

2 tests (100.0%) were fully cached saving 460ms.


Test

e2e/vendored_node

All tests were cache hits

1 test (100.0%) was fully cached saving 229ms.


Buildifier      Format

@jbedard jbedard force-pushed the js_library-trim-store-info-except-links branch from 8391337 to 01ce326 Compare July 18, 2024 18:05
@jbedard jbedard force-pushed the js_library-trim-store-info-except-links branch 2 times, most recently from 0205758 to 5664ebc Compare July 18, 2024 18:29
@jbedard jbedard marked this pull request as ready for review July 18, 2024 18:31
@jbedard jbedard requested review from thesayyn and gregmagolan July 18, 2024 18:31
@jbedard jbedard force-pushed the js_library-trim-store-info-except-links branch from 5664ebc to 7f3c785 Compare July 18, 2024 19:13
@jbedard jbedard force-pushed the js_library-trim-store-info-except-links branch from 7f3c785 to c8ce28c Compare July 20, 2024 01:22
@jbedard jbedard marked this pull request as draft July 20, 2024 06:00
@jbedard jbedard force-pushed the js_library-trim-store-info-except-links branch from c8ce28c to 1f2cdf8 Compare July 24, 2024 21:31
@gregmagolan gregmagolan force-pushed the js_library-trim-store-info-except-links branch from 85798f2 to ed71f4c Compare July 25, 2024 15:36
@jbedard jbedard marked this pull request as ready for review July 25, 2024 18:47
@jbedard jbedard merged commit 002b638 into aspect-build:main Jul 25, 2024
98 checks passed
@jbedard jbedard deleted the js_library-trim-store-info-except-links branch July 25, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Missing test for js_library "sandwich" no-type-check
2 participants