Skip to content

Conversation

@mmaker
Copy link
Member

@mmaker mmaker commented Jan 17, 2023

Description

Inform the user about how to run benchmarks in arkworks.

Closes #576.


Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (master)
  • Linked to GitHub issue with discussion and accepted design OR have an explanation in the PR that describes this work.
  • Wrote unit tests
  • Updated relevant documentation in the code
  • Added a relevant changelog entry to the Pending section in CHANGELOG.md
  • Re-reviewed Files changed in the GitHub PR explorer

Inform the user about how to run benchmarks in arkworks.
@mmaker mmaker requested review from a team as code owners January 17, 2023 16:59
@mmaker mmaker requested review from Pratyush, mmagician and weikengchen and removed request for a team January 17, 2023 16:59
@Pratyush Pratyush changed the title Create README.md Create README.md for bench-templates Jan 17, 2023
@mmagician
Copy link
Member

Great! Thanks

@Pratyush Pratyush merged commit 0a502bc into master Jan 17, 2023
@Pratyush Pratyush deleted the mmaker-patch-1 branch January 17, 2023 17:43
andrewmilson added a commit to andrewmilson/algebra that referenced this pull request Feb 9, 2023
* upstream/master:
  Add a note on `add_assign_mixed` to CHANGELOG (arkworks-rs#600)
  Fix linting on nightly Rust (arkworks-rs#598)
  Build docs correctly on docs.rs (arkworks-rs#590)
  Set correct minimum supported Rust version (arkworks-rs#592)
  Add back pairing benchmarks. (arkworks-rs#586)
  Create test-templates/README (arkworks-rs#585)
  Create README.md for `bench-templates` (arkworks-rs#583)
  Update `master` branch to 0.4.0 (arkworks-rs#582)
  Unify model configs (arkworks-rs#580)
  Correctly evaluate over domain when `self` is zero polynomial (arkworks-rs#575)
  Improve `impl From<u128> for Fp` (arkworks-rs#573)
  should just check the top bit, not two bits (arkworks-rs#560)
paberr pushed a commit to paberr/algebra that referenced this pull request Feb 22, 2023
Co-authored-by: Pratyush Mishra <pratyushmishra@berkeley.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove bench-templates

3 participants