Unify model configs #580
Merged
Unify model configs #580
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmagician
requested review from
Pratyush and
weikengchen
and removed request for
a team
weikengchen
approved these changes
Jan 16, 2023
andrewmilson
added a commit
to andrewmilson/algebra
that referenced
this pull request
Feb 9, 2023
* upstream/master: Add a note on `add_assign_mixed` to CHANGELOG (arkworks-rs#600) Fix linting on nightly Rust (arkworks-rs#598) Build docs correctly on docs.rs (arkworks-rs#590) Set correct minimum supported Rust version (arkworks-rs#592) Add back pairing benchmarks. (arkworks-rs#586) Create test-templates/README (arkworks-rs#585) Create README.md for `bench-templates` (arkworks-rs#583) Update `master` branch to 0.4.0 (arkworks-rs#582) Unify model configs (arkworks-rs#580) Correctly evaluate over domain when `self` is zero polynomial (arkworks-rs#575) Improve `impl From<u128> for Fp` (arkworks-rs#573) should just check the top bit, not two bits (arkworks-rs#560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since BLS12 and BW6 already had
final_exponentiationandmulti_miller_loopas part of the{BLS12/BW6}Config, this PR adds it the same methods forBnConfig,MNT4ConfigandMNT6Config, for consistency.Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer