should just check the top bit, not two bits #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmagician
requested review from
Pratyush and
weikengchen
and removed request for
a team
Member
|
Let me read the code a bit. The reason is that this no-carry implementation was originally for fields where the top two bits are zero (since, in arkworks-rs, previously, the top bit always must be zero). I need to think about whether this is intended. |
Member
|
We actually haven't implemented the squaring optimization; right now our squaring code only uses the flag when deciding which assembly routine to call. Also, our code now supports 64 * k bit moduli, so we need to check if the top bit is zero still, I believe |
Member
Author
Pratyush
approved these changes
Jan 10, 2023
andrewmilson
added a commit
to andrewmilson/algebra
that referenced
this pull request
Feb 9, 2023
* upstream/master: Add a note on `add_assign_mixed` to CHANGELOG (arkworks-rs#600) Fix linting on nightly Rust (arkworks-rs#598) Build docs correctly on docs.rs (arkworks-rs#590) Set correct minimum supported Rust version (arkworks-rs#592) Add back pairing benchmarks. (arkworks-rs#586) Create test-templates/README (arkworks-rs#585) Create README.md for `bench-templates` (arkworks-rs#583) Update `master` branch to 0.4.0 (arkworks-rs#582) Unify model configs (arkworks-rs#580) Correctly evaluate over domain when `self` is zero polynomial (arkworks-rs#575) Improve `impl From<u128> for Fp` (arkworks-rs#573) should just check the top bit, not two bits (arkworks-rs#560)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While working on #559, I realized that the condiditon for mul and squaring are the same (potenitally a copy paste error?). Since we're using this optimisation (our method docs), we should probably change the condition to match gnark's.
Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.
Pendingsection inCHANGELOG.mdFiles changedin the GitHub PR explorer