Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: configurable windows os version #5546

Closed
wants to merge 474 commits into from
Closed

feat: configurable windows os version #5546

wants to merge 474 commits into from

Conversation

mweibel
Copy link
Contributor

@mweibel mweibel commented Mar 30, 2021 •
edited
Loading

Allows to configure the windows version used for argoexec (see #5376). This allows us to easily build a version of the argoexec docker image without the need to adjust the Dockerfile itself (instead just pass --build-arg IMAGE_OS_VERSION=1909).

This changes additionally the golang version used to the latest 1.13 version, as at least 1.13.8 is needed to fix an issue with windows (https://github.com/golang/go/issues?q=milestone%3AGo1.13.8+label%3ACherryPickApproved, golang/go#36575).

The IMAGE_OS and IMAGE_ARCH build args were unused and hence I removed them.

possibly @lippertmarkus to review? :)

Checklist:

terrytangyuan and others added 30 commits February 19, 2021 11:49
@terrytangyuan
feat: Support automatically create OSS bucket if not exists (argoproj…
4611a16 
…#5133)

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@alexec
build: Fix build of argocli (argoproj#5150)
b54f13d 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@terrytangyuan @simster7
fix: Append the error message prior to offloading node status (argopr…
0f9b22b 
…oj#5043)

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>

Co-authored-by: Simon Behar <simbeh7@gmail.com>
@dcherman
fix: send periodic keepalive packets on eventstream connections (argo…
d33b5cc 
…proj#5101)
@simster7
fix: Better message formating for nodes (argoproj#5160)
bec80c8 
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@alexec
fix(executor): Do not make unneeded get pod when no sidecars (argop…
91528cc 
…roj#5161)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@fwfichtner
docs: Add DLR to USERS.md (argoproj#5157)
6618f47 
Signed-off-by: Fichtner, Florian Willy <florian.fichtner@dlr.de>
@terrytangyuan
feat(controller): Support pod GC strategy based on label selector on …
d9fb0c3 
…pods (argoproj#5090)

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@simster7
fix: Fix node filters in UI (argoproj#5162)
4b78a7e 
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@simster7
fix: Specify where in YAML validation error occurred (argoproj#5174)
a9c4200 
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@simster7
chore: Add missing CLI short docstrings (argoproj#5175)
8af3595 
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@alexec
feat(controller) Emissary executor. (argoproj#4925)
ab36166 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
docs: Grafana dashboard link added to metrics.md (argoproj#5165)
7cee66c 
Signed-off-by: Alexandre <alexandre@insideboard.com>
@crenshaw-dev
docs: typo (argoproj#5183)
71bf06c
@crenshaw-dev
docs: document the WorkflowTemplate workflowMetadata feature (argopro…
a46ff82 
…j#5177)
@alexec
test: Add additional resource template test (argoproj#5166)
8a8759f 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
feat(server): Enforce TLS >= v1.2 (argoproj#5172)
199016a 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec
fix(controller): Fix timezone support. Fixes argoproj#5181 (argoproj#…
e5a5f03 
…5182)

Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7
fix: Propagate URL changes to react state (argoproj#5188)
f5dcd1b 
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@alexec
fix(executor): Fix emissary bugs (argoproj#5187)
23415b2 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@simster7
fix: Consder templateRef when filtering by tag (argoproj#5190)
2abf08e 
Signed-off-by: Simon Behar <simbeh7@gmail.com>
@simster7
fix: Ensure whitespaces is allowed between name and bracket (argoproj…
26ce0c0 
…#5176)

Signed-off-by: Simon Behar <simbeh7@gmail.com>
@terrytangyuan
docs: Document the new OnTransientError retry policy (argoproj#5196)
4635d35 
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@dinever
feat(cli): Add cost optimization nudges for Argo CLI (argoproj#5168)
4881111 
* feat(cli): Add cost optimization nudges for Argo CLI

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>

* feat(cli): Add --no-nudges option to disable nudges output for argo list

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>

* feat(cli): Add security nudges for get command

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>

* feat(cli): Discard returned values for consistency

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>

* feat(cli): Update docs

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>

* feat(cli): goimports

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>

* refactor(cli): Move security nudges printing code to the printer util pkg

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>
@brandonaikey
docs: workflow-controller-configmap.md entry about argo-server. (argo…
e282fcc 
…proj#5195)

Signed-off-by: Brandon <brandon@allbitson.com>
@alexec
fix(controller): More emissary minor bugs (argoproj#5193)
8acdb1b 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@lippertmarkus
fix(controller): Support emissary on Windows (argoproj#5203)
47ac323 
Signed-off-by: Markus Lippert <lippertmarkus@gmx.de>
@alexec
chore: Tidy up test/verification (argoproj#5209)
d83cf21 
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@zachaller
fix(controller): Leader Lease Shared Name (argoproj#5214)
f0e8df0 
Signed-off-by: Zach Aller <zachaller@hotmail.com>
@simster7
fix: Checkbox is not clickable (argoproj#5213)
694690b 
Signed-off-by: Simon Behar <simbeh7@gmail.com>
christopheblin and others added 21 commits April 28, 2021 10:45
@christopheblin
docs: Update managed-namespace.md (argoproj#5768)
9dd3c6a 
mention that CRD are used and so cluster admin is needed

Signed-off-by: Christophe BLIN <cblin@monkeyfactory.fr>
@dinever
fix(ui): Fix an UI dropdown flickering issue (argoproj#5772)
cb55cba 
Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>
@alexec @dinever
docs: Add training doc (argoproj#5777)
4aff34c 
Co-authored-by: dinever <dingpeixuan911@gmail.com>
@iven
chore: Prevent free-port.sh from killing browsers (argoproj#5791)
26f08c1 
Signed-off-by: Iven Hsu <ivenvd@gmail.com>
@NikeNano
upgrade github.com/gogo/protobuf (argoproj#5780)
66c7709 
Signed-off-by: NikeNano <niklas.sven.hansson@gmail.com>
@kennytrytek
feat: Emit WorkflowNodeRunning Event (argoproj#5531)
3cdb22a 
* feat: Emit WorkflowNodeRunning event

 - Issue argoproj#5320

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>

* feat: Emit WorkflowNodeRunning event

 - Remove redundant onNodeComplete function.
 - Separate recording event in assess_node_status to its own conditional statement.
 - Rename function for clarity.

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>

* feat: Emit WorkflowNodeRunning event

 - Consolidate all WorkflowNode* events to one code path.

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>

* feat: Emit WorkflowNodeRunning event

 - Remove extra loop in event-sending logic.
 - Move phase event recording to immediately after woc is updated.

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>

* feat: Emit WorkflowNodeRunning event

 - Reassign woc.wf.TypeMeta during persistUpdates, since the Workflow
   representation returned from the server does not add this field.

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>

* feat: Emit WorkflowNodeRunning event

 - Use DeepCopy for event reporting to avoid modifying the active node.

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>

* feat: Emit WorkflowNodeRunning event

 - Use objects instead of pointers in the method signature to simplify things.

Signed-off-by: Kenny Trytek <kenneth.g.trytek@gmail.com>
@terrytangyuan
feat: Support bucket lifecycle for OSS artifact driver (argoproj#5731)
4a55e6f
@sa-
docs: fix typo (argoproj#5781)
01f37b8
@yu-croco
fix(docs): Fix yaml snippet (argoproj#5788)
7e974dc
@alexec
test: Refactoring test JSON marshalling. (argoproj#5785)
0283faf
@lowc1012
fix: change log level to warn level (argoproj#5790)
4af0113 
Signed-off-by: Ryan Lo <lowc1012@gmail.com>
@dinever
build: fix codegen failure on master branch (argoproj#5799)
418395b 
Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>
@terrytangyuan
fix: Reset workflow started time to current when retrying workflow. F…
4b3a30f 
…ixes argoproj#5796 (argoproj#5798)

Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@dinever
feat(controller): Add validation for ContainerSet (argoproj#5758)
076ff18
@markterm
fix: Node set updating global output parameter updates global. argopr…
8f2acee 
…oj#5699 (argoproj#5700)
@dinever
feat(cli): Retry workflows by label selector and field selector (argo…
b9a79e0 
…proj#5795)
@Radolumbo
fix: Add note about hyphenated variables (argoproj#5805)
bdd44c7 
Signed-off-by: Nick Palumbo <npalumbo8@bloomberg.net>

Co-authored-by: Nick Palumbo <npalumbo8@bloomberg.net>
@softwarebloat
docs: fix typo in async-pattern page (argoproj#5810)
a65cc3e 
Signed-off-by: softwarebloat <nico.lino1991@gmail.com>
@terrytangyuan
chore: Surface parse duration error in operator (argoproj#5814)
3f80866 
Signed-off-by: terrytangyuan <terrytangyuan@gmail.com>
@dinever
feat(cli): resubmit workflows by label and field selector (argoproj#5807
507b92c 
)

Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>
@mweibel
feat: configurable windows os version
5440faa 
allows to specify windows OS version using `--build-arg
IMAGE_OS_VERSION=1909` so users can build their own argoexec using the
appropriate underlying windows version (see argoproj#5367).

Signed-off-by: Michael Weibel <michael@helio.exchange>
@mweibel mweibel force-pushed the configurable-dockerfile-windows branch from 267b585 to 5440faa Compare May 4, 2021 19:03
@mweibel mweibel closed this May 4, 2021
@mweibel mweibel mentioned this pull request May 4, 2021
Merged
1 task
@mweibel
Copy link
Contributor Author

mweibel commented May 4, 2021

d'oh - forgot you can't change the target branch in GitHub. Created #5816 with the new target branch.

@agilgur5 agilgur5 added solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate) area/windows Windows Container support area/executor area/build Build or GithubAction/CI issues labels Jun 6, 2024
@argoproj argoproj locked as resolved and limited conversation to collaborators Jun 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexec alexec alexec requested changes

@simster7 simster7 simster7 approved these changes

@lippertmarkus lippertmarkus lippertmarkus approved these changes

@jessesuen jessesuen Awaiting requested review from jessesuen jessesuen will be requested when the pull request is marked ready for review jessesuen is a code owner

Assignees
No one assigned
Labels
area/build Build or GithubAction/CI issues area/executor area/windows Windows Container support solution/superseded This PR or issue has been superseded by another one (slightly different from a duplicate)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.