Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Retry workflows by label selector and field selector #5795

Merged
merged 2 commits into from
May 3, 2021

Conversation

dinever
Copy link
Member

@dinever dinever commented May 3, 2021

Part of #3931 and #5584.

This is very similar to #5752

By Label By Field
Screen Shot 2021-05-03 at 1 33 22 AM Screen Shot 2021-05-03 at 1 34 17 AM

Note:

  1. Retrying many workflows will print out each workflow individually, which is lots of content (see the above screenshot). Maybe we should. consider printing out a wide list instead when there are multiple workflows to be retried? Like this:
    Screen Shot 2021-05-03 at 1 37 04 AM

@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #5795 (ee2e8d8) into master (4b3a30f) will increase coverage by 0.14%.
The diff coverage is 60.71%.

❗ Current head ee2e8d8 differs from pull request most recent head efae433. Consider uploading reports for the commit efae433 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5795      +/-   ##
==========================================
+ Coverage   46.79%   46.94%   +0.14%     
==========================================
  Files         245      245              
  Lines       15398    15433      +35     
==========================================
+ Hits         7206     7245      +39     
+ Misses       7280     7275       -5     
- Partials      912      913       +1     
Impacted Files Coverage Δ
cmd/argo/commands/retry.go 43.03% <60.71%> (+43.03%) ⬆️
cmd/argo/commands/get.go 57.28% <0.00%> (+0.97%) ⬆️
cmd/argoexec/commands/emissary.go 50.00% <0.00%> (+1.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b3a30f...efae433. Read the comment docs.

@dinever dinever force-pushed the retry-selectors branch 4 times, most recently from 6db3aa3 to fb59339 Compare May 3, 2021 16:32
@alexec alexec self-assigned this May 3, 2021
Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>
Signed-off-by: Peixuan Ding <dingpeixuan911@gmail.com>
@alexec alexec merged commit b9a79e0 into argoproj:master May 3, 2021
@alexec alexec added this to the v3.1 milestone May 3, 2021
@sarabala1979 sarabala1979 mentioned this pull request May 4, 2021
33 tasks
@sarabala1979 sarabala1979 mentioned this pull request May 13, 2021
35 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants