Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --selector and other useful flags to argo {stop,terminate,resume,etc.} #3931

Closed
simster7 opened this issue Sep 2, 2020 · 8 comments · Fixed by #5807
Closed

Add --selector and other useful flags to argo {stop,terminate,resume,etc.} #3931

simster7 opened this issue Sep 2, 2020 · 8 comments · Fixed by #5807
Assignees
Labels
good first issue Good for newcomers type/feature Feature request

Comments

@simster7
Copy link
Member

simster7 commented Sep 2, 2020

Summary

Add --selector and other useful flags to argo {stop,terminate,resume,etc.}

Use Cases

You can list certain workflows with argo list --selector ..., you should be able to stop the same list of workflows


Message from the maintainers:

Impacted by this bug? Give it a 👍. We prioritise the issues with the most 👍.

@simster7 simster7 added type/feature Feature request good first issue Good for newcomers help wanted labels Sep 2, 2020
@noahingh
Copy link
Contributor

noahingh commented Sep 4, 2020

@simster7 If nobody takes this issue, can I try it as my first contribution?

@simster7
Copy link
Member Author

simster7 commented Sep 4, 2020

Feel free to do so!

@stuckinforloop
Copy link

@simster7 If nobody takes this issue, can I try it as my first contribution?

I would also like to do so. Is there any way we can collaborate on this as I am also new to Golang.

@rajneeshbajaj
Copy link

I can also assist, please let me know.

@noahingh
Copy link
Contributor

noahingh commented Sep 8, 2020

@neel229 @rajneeshbajaj I'll create a PR where we can work together first and let you know. Sorry for late.

@noahingh
Copy link
Contributor

noahingh commented Sep 8, 2020

@rajneeshbajaj @neel229 I've created the draft to work (#3962). I'm planning to add options (--selector, --field-selector) to these commands:

  • stop
  • terminate
  • resume
  • retry

Please comment if you have any questions.

@simster7 One question, how could I add a unit test for codes of command?

@simster7
Copy link
Member Author

simster7 commented Sep 8, 2020

We're refactoring our CLI testing code right now, but for now you can add them under test/e2e/cli_test.go

@dratler
Copy link

dratler commented Sep 20, 2020

Hi @simster7 ,
is this for the greb ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers type/feature Feature request
Projects
None yet
5 participants