Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Refactoring test JSON marshalling. #5785

Merged
merged 4 commits into from
May 3, 2021
Merged

Conversation

alexec
Copy link
Contributor

@alexec alexec commented Apr 30, 2021

No description provided.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@codecov
Copy link

codecov bot commented Apr 30, 2021

Codecov Report

Merging #5785 (d64ea84) into master (cb55cba) will decrease coverage by 0.17%.
The diff coverage is 15.38%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #5785      +/-   ##
==========================================
- Coverage   46.93%   46.76%   -0.18%     
==========================================
  Files         244      245       +1     
  Lines       15313    15350      +37     
==========================================
- Hits         7187     7178       -9     
- Misses       7219     7262      +43     
- Partials      907      910       +3     
Impacted Files Coverage Δ
pkg/apis/workflow/v1alpha1/marshall.go 10.81% <10.81%> (ø)
workflow/hydrator/fake/always.go 100.00% <100.00%> (ø)
workflow/metrics/server.go 12.50% <0.00%> (-4.17%) ⬇️
server/workflow/workflow_server.go 40.45% <0.00%> (-2.28%) ⬇️
workflow/controller/operator.go 70.85% <0.00%> (-0.27%) ⬇️
cmd/argo/commands/get.go 56.95% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb55cba...d64ea84. Read the comment docs.

Signed-off-by: Alex Collins <alex_collins@intuit.com>
Signed-off-by: Alex Collins <alex_collins@intuit.com>
@alexec alexec requested a review from simster7 May 3, 2021 14:52
@alexec alexec marked this pull request as ready for review May 3, 2021 14:52
@alexec alexec merged commit 0283faf into argoproj:master May 3, 2021
@alexec alexec deleted the json branch May 3, 2021 17:06
@sarabala1979 sarabala1979 mentioned this pull request May 4, 2021
33 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants