docs(argo-cd): Add Openshift 4 specific Route command to NOTES.txt #855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Openshift specific commands for making server UI accessable.
shshanmu
requested review from
davidkarlsen,
mbevc1,
oliverbaehler,
seanson and
yann-soubeyrand
as code owners
davidkarlsen
reviewed
Aug 2, 2021
Co-authored-by: David J. M. Karlsen <david@davidkarlsen.com>
Added Openshift specific commands for making server UI accessable. Signed-off-by: Shabin Shanmugalingam <shabin.shanmugalingam@t-systems.com>
Signed-off-by: smcavallo <smcavallo@hotmail.com> Signed-off-by: Shabin Shanmugalingam <shabin.shanmugalingam@t-systems.com>
Chnaged appVersion and added new annotation.
argoproj#846) Co-authored-by: Marco Kilchhofer <mkilchhofer@users.noreply.github.com> Signed-off-by: Shabin Shanmugalingam <shabin.shanmugalingam@t-systems.com>
Signed-off-by: smcavallo <smcavallo@hotmail.com> Signed-off-by: Shabin Shanmugalingam <shabin.shanmugalingam@t-systems.com>
…j#849) Signed-off-by: Lucas Bickel <lucas.bickel@adfinis.com> Signed-off-by: Shabin Shanmugalingam <shabin.shanmugalingam@t-systems.com>
Co-authored-by: David J. M. Karlsen <david@davidkarlsen.com> Signed-off-by: Shabin Shanmugalingam <shabin.shanmugalingam@t-systems.com>
mkilchhofer
reviewed
Aug 7, 2021
| In case you are deploying on openshift 4 | ||
| 3. You have to use the Openshift Routes. For that use folowing command: | ||
|
|
||
| oc create route passthrough YOUR_ROUTE_NAME --service=YOUR_SERVICE --port=https --insecure-policy=Redirect |
There was a problem hiding this comment.
Why hardcoding a dummy name for service? You have access to helm templating here. Please use:
Suggested change
| oc create route passthrough YOUR_ROUTE_NAME --service=YOUR_SERVICE --port=https --insecure-policy=Redirect | |
| oc create route passthrough YOUR_ROUTE_NAME --service={{ template "argo-cd.server.fullname" . }} --port=https --insecure-policy=Redirect |
mkilchhofer
changed the title
mkilchhofer
reviewed
Sep 16, 2021
| @@ -8,6 +8,14 @@ In order to access the server UI you have the following options: | |||
| - Add the annotation for ssl passthrough: https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/ingress.md#option-1-ssl-passthrough | |||
| - Add the `--insecure` flag to `server.extraArgs` in the values file and terminate SSL at your ingress: https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/ingress.md#option-2-multiple-ingress-objects-and-hosts | |||
|
|
|||
| In case you are deploying on openshift 4 | |||
There was a problem hiding this comment.
Suggested change
| In case you are deploying on openshift 4 | |
| {{- if .Values.openshift.enabled }} | |
| In case you are deploying on openshift 4 |
Also, we should use the conditional to not print this message on all non-OSE environments.
|
I'll close this one as there is no activity for more than one month. Feel free to reopen it or file a new one if needed. But thank you anyway for contributing to this project. 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Openshift specific commands for making server UI accessable.
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.