Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(argo-cd): Add Openshift 4 specific Route command to NOTES.txt #855

Closed
wants to merge 12 commits into from
Closed

docs(argo-cd): Add Openshift 4 specific Route command to NOTES.txt #855

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
f11dde4
Update NOTES.txt
shshanmu Jul 21, 2021
f0f88fc
Merge branch 'argoproj:master' into master
shshanmu Aug 2, 2021
cfe3c59
Update charts/argo-cd/templates/NOTES.txt
shshanmu Aug 2, 2021
a063ece
Update NOTES.txt
shshanmu Jul 21, 2021
54cf92c
feat(argo-cd): Bump default version to v2.0.5 (#844)
smcavallo Jul 27, 2021
d22212b
Update Chart.yaml
shshanmu Aug 2, 2021
64be07a
fix(argo-cd): Deprecate the static assets flag passed to argocd-serve…
Jul 27, 2021
94d8e1e
argocd - update misc dependencies (#847)
smcavallo Jul 28, 2021
9493915
fix(argo-cd): re-enable not yet deprecated staticassets flag (#849)
hairmare Jul 28, 2021
b3ac51e
Update charts/argo-cd/templates/NOTES.txt
shshanmu Aug 2, 2021
cfcedeb
Merge Chart.yaml
shabin100 Aug 2, 2021
521fbe0
Update Chart.yaml
shshanmu Aug 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/argo-cd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
apiVersion: v2
appVersion: 2.0.5
appVersion: 2.0.6
description: A Helm chart for ArgoCD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 3.11.1
Expand All @@ -21,4 +21,4 @@ dependencies:
condition: redis-ha.enabled
annotations:
artifacthub.io/changes: |
- "[Changed]: Set server.staticAssets.enabled=true since Argo CD 2.0.5 still needs it"
- "[Changed]: Openshift 4 specific Route command added in the NOTES.txt file"
8 changes: 8 additions & 0 deletions charts/argo-cd/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,14 @@ In order to access the server UI you have the following options:
- Add the annotation for ssl passthrough: https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/ingress.md#option-1-ssl-passthrough
- Add the `--insecure` flag to `server.extraArgs` in the values file and terminate SSL at your ingress: https://github.com/argoproj/argo-cd/blob/master/docs/operator-manual/ingress.md#option-2-multiple-ingress-objects-and-hosts

In case you are deploying on openshift 4
Copy link
Member

@mkilchhofer mkilchhofer Sep 16, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
In case you are deploying on openshift 4
{{- if .Values.openshift.enabled }}
In case you are deploying on openshift 4

Also, we should use the conditional to not print this message on all non-OSE environments.

3. You have to use the Openshift Routes. For that use folowing command:

oc create route passthrough YOUR_ROUTE_NAME --service=YOUR_SERVICE --port=https --insecure-policy=Redirect
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why hardcoding a dummy name for service? You have access to helm templating here. Please use:

Suggested change
oc create route passthrough YOUR_ROUTE_NAME --service=YOUR_SERVICE --port=https --insecure-policy=Redirect
oc create route passthrough YOUR_ROUTE_NAME --service={{ template "argo-cd.server.fullname" . }} --port=https --insecure-policy=Redirect


After that execute the following command to get the server UI link:

echo https://$(oc get routes argocd -o=jsonpath='{ .spec.host }')

After reaching the UI the first time you can login with username: admin and the random password generated during the installation. You can find the password by running:

Expand Down