fix(argo-cd): re-enable not yet deprecated staticassets flag #849
+3
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lucas Bickel <lucas.bickel@adfinis.com>
hairmare
requested review from
davidkarlsen,
mbevc1,
oliverbaehler,
seanson and
yann-soubeyrand
as code owners
shshanmu
pushed a commit
to shshanmu/argo-helm
that referenced
this pull request
Aug 2, 2021
…j#849) Signed-off-by: Lucas Bickel <lucas.bickel@adfinis.com> Signed-off-by: Shabin Shanmugalingam <shabin.shanmugalingam@t-systems.com>
thomascjohnson
pushed a commit
to thomascjohnson/argo-helm
that referenced
this pull request
Aug 10, 2021
…j#849) Signed-off-by: Lucas Bickel <lucas.bickel@adfinis.com> Signed-off-by: thomascjohnson <thomascjohnson@gmail.com>
thomascjohnson
pushed a commit
to thomascjohnson/argo-helm
that referenced
this pull request
Aug 10, 2021
…j#849) Signed-off-by: Lucas Bickel <lucas.bickel@adfinis.com> Signed-off-by: thomascjohnson <thomascjohnson@gmail.com>
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Sep 7, 2021
…j#849) Signed-off-by: Lucas Bickel <lucas.bickel@adfinis.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable
server.staticAssets.enabledby default (was disabled in #846). It looks like neither argoproj/argo-cd@561452a or argoproj/argo-cd@e68618d have made it into a release yet so the default should stick to enabled for now.Signed-off-by: Lucas Bickel lucas.bickel@adfinis.com
Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.Does not address #843 but adresses all the comments from people getting hit by this.