Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argocd): update Notification Service comment #1221

Closed
wants to merge 2 commits into from
Closed

chore(argocd): update Notification Service comment #1221

wants to merge 2 commits into from

Conversation

yu-croco
Copy link
Collaborator

This PR is revert of #1220 ( because the configuration already existed 🙇 ) and is to improve comment.

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • I have bumped the chart version according to versioning
  • I have updated the documentation according to documentation
  • I have updated the chart changelog with all the changes that come with this pull request according to changelog.
  • Any new values are backwards compatible and/or have sensible default.
  • I have signed off all my commits as required by DCO.
  • My build is green (troubleshooting builds).

Changes are automatically published when merged to master. They are not published on branches.

@yu-croco yu-croco marked this pull request as draft April 12, 2022 13:27
@yu-croco yu-croco closed this Apr 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant