feat(argo-cd): Add ability to set Notification Services #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
yu-croco
changed the title
yu-croco
requested review from
davidkarlsen,
yann-soubeyrand and
mbevc1
as code owners
mbevc1
approved these changes
Apr 12, 2022
|
Oh I am too late :-D This functionality was already there but has another name: https://github.com/argoproj/argo-helm/blob/master/charts/argo-cd/values.yaml#L2191-L2196 |
|
oh, I'm so sorry for missing it... 😇 |
|
Shall I make revert PR ? 👀 |
|
ahh, missed it as well :D |
That would be great. Maybe we can extend Line 2191 with something of your description? - # -- Configures notification services
+ # -- Configures notification services such as slack, email or custom webhook |
|
Sounds good to me 👍 |
|
Sure, I will make PR soon. 🙋 |
This was referenced Apr 12, 2022
|
I created PR. Please check 🙇 |
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
Signed-off-by: yu-croco <yuki.kita22@gmail.com>
terrych0u
pushed a commit
to terrych0u/argo-helm
that referenced
this pull request
Aug 4, 2022
* Revert "feat(argo-cd): Add ability to set Notification Services (argoproj#1220)" This reverts commit 7932e5a. Signed-off-by: yu-croco <yuki.kita22@gmail.com> * chore(argocd): update comment to clarify usecase Signed-off-by: yu-croco <yuki.kita22@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yu-croco yuki.kita22@gmail.com
According to official doc, we can set Notification Services on
argocd-notifications-cmConfigMap, but there was no configuration against them. So I added them. 🙋Note on DCO:
If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.
Checklist:
Changes are automatically published when merged to
master. They are not published on branches.