feat(argo-cd): Add ability to set Notification Services (argoproj#1220)

Signed-off-by: yu-croco <yuki.kita22@gmail.com>
terrych0u · Aug 4, 2022 · ab14d16 · ab14d16
1 parent a97887c
commit ab14d16
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 2 deletions.
diff --git a/charts/argo-cd/Chart.yaml b/charts/argo-cd/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 appVersion: v2.3.3
 description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
 name: argo-cd
-version: 4.5.1
+version: 4.5.2
 home: https://github.com/argoproj/argo-helm
 icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
 keywords:
@@ -21,4 +21,4 @@ dependencies:
     condition: redis-ha.enabled
 annotations:
   artifacthub.io/changes: |
-    - "[Fixed]: Removed status field from ApplicationSet CRD"
+    - "[Feat]: Add ability to set Notification Services"
diff --git a/charts/argo-cd/README.md b/charts/argo-cd/README.md
@@ -776,6 +776,7 @@ NAME: my-release
 | notifications.serviceAccount.annotations | object | `{}` | Annotations applied to created service account |
 | notifications.serviceAccount.create | bool | `true` | Specifies whether a service account should be created |
 | notifications.serviceAccount.name | string | `"argocd-notifications-controller"` | The name of the service account to use. |
+| notifications.services | object | `{}` | The notification services such as slack, email or custom webhook. This will be stored on `notifications.cm.name` ConfigMap. |
 | notifications.subscriptions | list | `[]` | Contains centrally managed global application subscriptions |
 | notifications.templates | object | `{}` | The notification template is used to generate the notification content |
 | notifications.tolerations | list | `[]` | [Tolerations] for use with node taints |

diff --git a/charts/argo-cd/templates/argocd-notifications/configmap.yaml b/charts/argo-cd/templates/argocd-notifications/configmap.yaml
@@ -24,4 +24,7 @@ data:
   {{- with .Values.notifications.triggers }}
     {{- toYaml . | nindent 2 }}
   {{- end }}
+  {{- with .Values.notifications.services }}
+    {{- toYaml . | nindent 2 }}
+  {{- end }}
 {{- end }}
diff --git a/charts/argo-cd/values.yaml b/charts/argo-cd/values.yaml
@@ -2580,3 +2580,9 @@ notifications:
 
       # -- [Node selector]
       nodeSelector: {}
+
+  # -- The notification services such as slack, email or custom webhook. This will be stored on `notifications.cm.name` ConfigMap.
+  ## For more information: https://argocd-notifications.readthedocs.io/en/stable/services/overview/
+  services: {}
+    # service.slack: |
+    #   token: $slack-token