Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(argocd): update Notification Service comment #1221

Closed
wants to merge 2 commits into from
Closed

chore(argocd): update Notification Service comment #1221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ed0397f
Revert "feat(argo-cd): Add ability to set Notification Services (#1220)"
yu-croco Apr 12, 2022
a784f32
chore(argo-cd): update comment to show usecase.
yu-croco Apr 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions charts/argo-cd/Chart.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ apiVersion: v2
appVersion: v2.3.3
description: A Helm chart for Argo CD, a declarative, GitOps continuous delivery tool for Kubernetes.
name: argo-cd
version: 4.5.2
version: 4.5.1
home: https://github.com/argoproj/argo-helm
icon: https://argo-cd.readthedocs.io/en/stable/assets/logo.png
keywords:
Expand All @@ -21,4 +21,4 @@ dependencies:
condition: redis-ha.enabled
annotations:
artifacthub.io/changes: |
- "[Feat]: Add ability to set Notification Services"
- "[Fixed]: Removed status field from ApplicationSet CRD"
1 change: 0 additions & 1 deletion charts/argo-cd/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -776,7 +776,6 @@ NAME: my-release
| notifications.serviceAccount.annotations | object | `{}` | Annotations applied to created service account |
| notifications.serviceAccount.create | bool | `true` | Specifies whether a service account should be created |
| notifications.serviceAccount.name | string | `"argocd-notifications-controller"` | The name of the service account to use. |
| notifications.services | object | `{}` | The notification services such as slack, email or custom webhook. This will be stored on `notifications.cm.name` ConfigMap. |
| notifications.subscriptions | list | `[]` | Contains centrally managed global application subscriptions |
| notifications.templates | object | `{}` | The notification template is used to generate the notification content |
| notifications.tolerations | list | `[]` | [Tolerations] for use with node taints |
Expand Down
3 changes: 0 additions & 3 deletions charts/argo-cd/templates/argocd-notifications/configmap.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,4 @@ data:
{{- with .Values.notifications.triggers }}
{{- toYaml . | nindent 2 }}
{{- end }}
{{- with .Values.notifications.services }}
{{- toYaml . | nindent 2 }}
{{- end }}
{{- end }}
8 changes: 1 addition & 7 deletions charts/argo-cd/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2188,7 +2188,7 @@ notifications:
# interval: 30s
# scrapeTimeout: 10s

# -- Configures notification services
# -- Configures notification services such as slack, email or custom webhook
# @default -- See [values.yaml]
## For more information: https://argocd-notifications.readthedocs.io/en/stable/services/overview/
notifiers: {}
Expand Down Expand Up @@ -2580,9 +2580,3 @@ notifications:

# -- [Node selector]
nodeSelector: {}

# -- The notification services such as slack, email or custom webhook. This will be stored on `notifications.cm.name` ConfigMap.
## For more information: https://argocd-notifications.readthedocs.io/en/stable/services/overview/
services: {}
# service.slack: |
# token: $slack-token