Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix broken version selector #13102

Merged
merged 1 commit into from
Apr 4, 2023
Merged

docs: fix broken version selector #13102

merged 1 commit into from
Apr 4, 2023

Conversation

cjc7373
Copy link
Contributor

@cjc7373 cjc7373 commented Apr 4, 2023

fixes #11999

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Toolchain Guide
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.

Please see Contribution FAQs if you have questions about your pull-request.

@cjc7373
docs: fix broken version selector
818e059 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
@cjc7373
Copy link
Contributor Author

cjc7373 commented Apr 4, 2023 •
edited
Loading

A preview: https://argo-cd--13102.org.readthedocs.build/en/13102/

@cjc7373 cjc7373 marked this pull request as ready for review April 4, 2023 16:04
@crenshaw-dev
Copy link
Member

You're a legend, thanks for this. Do you have any notion what the code was meant to do before it broke?

@crenshaw-dev
Copy link
Member

@reginapizza since it looks like you contributed the version dropdown. :-)

crenshaw-dev
crenshaw-dev approved these changes Apr 4, 2023
View reviewed changes
Copy link
Member

@crenshaw-dev crenshaw-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, if it causes other problems, we'll fix those then.

@crenshaw-dev crenshaw-dev enabled auto-merge (squash) April 4, 2023 16:08
@cjc7373
Copy link
Contributor Author

cjc7373 commented Apr 4, 2023

Do you have any notion what the code was meant to do before it broke?

As I metioned in #11999 (comment), the code toggles the display status of the dropdown. However, it conflicts with the code readthedocs injects..

@crenshaw-dev crenshaw-dev merged commit a379fd5 into argoproj:master Apr 4, 2023
@jannfis
Copy link
Member

jannfis commented Apr 4, 2023

/cherry-pick release-2.7
/cherry-pick release-2.6
/cherry-pick release-2.5
/cherry-pick release-2.4

@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Apr 4, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 4, 2023
@cjc7373
docs: fix broken version selector (#13102)
5222e1e 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
@jannfis
Copy link
Member

jannfis commented Apr 4, 2023

/cherry-pick release-2.6

@jannfis
Copy link
Member

jannfis commented Apr 4, 2023

/cherry-pick release-2.5

@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Apr 4, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 4, 2023
@cjc7373
docs: fix broken version selector (#13102)
6c8f911 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 4, 2023
@cjc7373
docs: fix broken version selector (#13102)
1ef0ace 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Apr 4, 2023
Merged
@jannfis
Copy link
Member

jannfis commented Apr 4, 2023

/cherry-pick release-2.4

@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this pull request Apr 4, 2023
Merged
gcp-cherry-pick-bot bot pushed a commit that referenced this pull request Apr 4, 2023
@cjc7373
docs: fix broken version selector (#13102)
078dffb 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Apr 4, 2023
@gcp-cherry-pick-bot @cjc7373
docs: fix broken version selector (#13102) (#13105)
f35c127 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
Co-authored-by: cjc7373 <niuchangcun@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Apr 4, 2023
@gcp-cherry-pick-bot @cjc7373
docs: fix broken version selector (#13102) (#13108)
38e5b67 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
Co-authored-by: cjc7373 <niuchangcun@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Apr 4, 2023
@gcp-cherry-pick-bot @cjc7373
docs: fix broken version selector (#13102) (#13107)
034e6cc 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
Co-authored-by: cjc7373 <niuchangcun@gmail.com>
crenshaw-dev pushed a commit that referenced this pull request Apr 4, 2023
@gcp-cherry-pick-bot @cjc7373
docs: fix broken version selector (#13102) (#13106)
a325c35 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
Co-authored-by: cjc7373 <niuchangcun@gmail.com>
@zachaller zachaller mentioned this pull request Apr 18, 2023
Merged
schakrad pushed a commit to schakrad/argo-cd that referenced this pull request Jul 24, 2023
@gcp-cherry-pick-bot @cjc7373 @schakrad
docs: fix broken version selector (argoproj#13102) (argoproj#13105)
4a9ad3f 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
Co-authored-by: cjc7373 <niuchangcun@gmail.com>
Signed-off-by: schakrad <58915923+schakrad@users.noreply.github.com>
yyzxw pushed a commit to yyzxw/argo-cd that referenced this pull request Aug 9, 2023
@cjc7373
docs: fix broken version selector (argoproj#13102)
d7fe3ae 
Signed-off-by: Harold Cheng <niuchangcun@gmail.com>
@agilgur5 agilgur5 mentioned this pull request Mar 19, 2024
Closed
This was referenced Jun 25, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crenshaw-dev crenshaw-dev crenshaw-dev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Version selector in our docs is broken
4 participants
@cjc7373 @crenshaw-dev @jannfis @agilgur5