Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version selector in our docs is broken #11999

Closed
3 tasks
jannfis opened this issue Jan 16, 2023 · 4 comments · Fixed by #13102
Closed
3 tasks

Version selector in our docs is broken #11999

jannfis opened this issue Jan 16, 2023 · 4 comments · Fixed by #13102
Assignees
Labels
bug Something isn't working

Comments

@jannfis
Copy link
Member

jannfis commented Jan 16, 2023

Checklist:

  • I've searched in the docs and FAQ for my answer: https://bit.ly/argocd-faq.
  • I've included steps to reproduce the bug.
  • I've pasted the output of argocd version.

Describe the bug

The version selector in our official docs is broken, i.e. the drop down is disabled. Users are only able to see the current version's (stable) docs, but not select a previous version or latest docs.

To Reproduce

Expected behavior

  • Docs for supported versions plus latest would be selectable

Screenshots

image

@jannfis jannfis added bug Something isn't working documentation labels Jan 16, 2023
@reginapizza reginapizza self-assigned this Jan 16, 2023
@christopherwood
Copy link

If it helps, the version selector works just fine in Google Chrome ("Version 109.0.5414.74 (Official Build) (64-bit)") on Ubuntu 22.04.
The version selector doesn't work in Firefox ("109.0 (64-bit)") on the same Ubuntu version.

@shuker85
Copy link
Contributor

Chrome 109 on MacOS it gets into the footer
Screenshot 2023-01-19 at 21 48 36

@Aym3nTN
Copy link
Contributor

Aym3nTN commented Feb 1, 2023

A weird finding, where it does work there is this "Error: No ad placements found" error that appears twice in the browser console; when it doesn't work that error only appears once. Maybe this observation could be helpful to debug this behavior.

215902045-a18cc4a2-106c-41ab-9eeb-5a5ceb757e6a

@cjc7373
Copy link
Contributor

cjc7373 commented Apr 4, 2023

The cause of the problem is that readthedocs injects a js called readthedocs-doc-embed.js, which adds the botton in the bottom left, and also adds a event listener to toggle version selector display status.
I searched readthedocs docs and issues and do not find any way to disable this behavior. So a quick fix is to delete our own event listener.

On the other hand, I support we move to github pages as proposed in #11175.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants