Allow non device type template parameter for output views in BVH::query() #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…redicateTag, ...) on view types
…redicateTag, ...) on view types
… queryDispatch() on BVH instead
… struct with all static methods
|
Yeah, I thought a way to fix this would be through templating on view types. The unfortunate side effect of this is that the view signatures are no longer easily distinguished (for example, value types). |
|
Well I was not necessarily planning on opening that PR yet because I am necessarily convinced whether I want to keep the |
…ndingVolumeHierarchyImpl.hpp
aprokop
requested changes
Apr 17, 2020
…:BoundingVolumeHierarchyImpl::
…non_device_type_template_param
aprokop
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #270
This will produce an example of bad error message as requested in #269 (comment)