Improve compilation error messages produced by BVH::query()

[dalg24]

Even more so since we added the callbacks, error messages produced by BVH::query() can be spectacularly bad.

[aprokop]

Please post an example.

[dalg24]

Please post an example.

See a2e80a4

Another good way to see that is try writing your own callback, odds are you will mess it up and you will understand the pain.

[dalg24]

Posting error message from Clang+CUDA build (which typically produce better error messages than NVCC)

In file included from /var/jenkins/workspace/ArborX_PR-271/examples/access_traits/example_cuda_access_traits.cpp:1:
In file included from /var/jenkins/workspace/ArborX_PR-271/src/ArborX.hpp:19:
In file included from /var/jenkins/workspace/ArborX_PR-271/src/ArborX_DistributedSearchTree.hpp:16:
In file included from /var/jenkins/workspace/ArborX_PR-271/src/details/ArborX_DetailsDistributedSearchTreeImpl.hpp:20:
/var/jenkins/workspace/ArborX_PR-271/src/ArborX_LinearBVH.hpp:90:55: error: no matching member function for call to 'queryDispatch'
    Details::BoundingVolumeHierarchyImpl<DeviceType>::queryDispatch(
    ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
/var/jenkins/workspace/ArborX_PR-271/examples/access_traits/example_cuda_access_traits.cpp:77:9: note: in instantiation of function template specialization 'ArborX::BoundingVolumeHierarchy<Kokkos::CudaSpace, void>::query<Kokkos::Cuda, Spheres, Kokkos::View<int *, Kokkos::Cuda> &, Kokkos::View<int *, Kokkos::Cuda> &>' requested here
    bvh.query(cuda, Spheres{d_a, d_a, d_a, d_a, N}, indices, offset);
        ^
/var/jenkins/workspace/ArborX_PR-271/src/details/ArborX_DetailsBoundingVolumeHierarchyImpl.hpp:166:3: note: candidate function template not viable: no known conversion from 'Kokkos::View<int *, Kokkos::Cuda>' to 'Kokkos::View<int *, Device<Cuda, CudaSpace> > &' for 5th argument
  queryDispatch(SpatialPredicateTag,
  ^
/var/jenkins/workspace/ArborX_PR-271/src/details/ArborX_DetailsBoundingVolumeHierarchyImpl.hpp:247:3: note: candidate function template not viable: no known conversion from 'Tag' (aka 'ArborX::Details::SpatialPredicateTag') to 'ArborX::Details::NearestPredicateTag' for 1st argument
  queryDispatch(NearestPredicateTag,
  ^
/var/jenkins/workspace/ArborX_PR-271/src/details/ArborX_DetailsBoundingVolumeHierarchyImpl.hpp:183:3: note: candidate function template not viable: requires at least 7 arguments, but 6 were provided
  queryDispatch(SpatialPredicateTag,
  ^
/var/jenkins/workspace/ArborX_PR-271/src/details/ArborX_DetailsBoundingVolumeHierarchyImpl.hpp:196:3: note: candidate function template not viable: requires at least 7 arguments, but 6 were provided
  queryDispatch(SpatialPredicateTag,
  ^
/var/jenkins/workspace/ArborX_PR-271/src/details/ArborX_DetailsBoundingVolumeHierarchyImpl.hpp:215:3: note: candidate function template not viable: requires at least 7 arguments, but 6 were provided
  queryDispatch(NearestPredicateTag,
  ^
/var/jenkins/workspace/ArborX_PR-271/src/details/ArborX_DetailsBoundingVolumeHierarchyImpl.hpp:228:3: note: candidate function template not viable: requires at least 7 arguments, but 6 were provided
  queryDispatch(NearestPredicateTag,
  ^
/var/jenkins/workspace/ArborX_PR-271/src/details/ArborX_DetailsBoundingVolumeHierarchyImpl.hpp:262:3: note: candidate function template not viable: requires at least 7 arguments, but 6 were provided
  queryDispatch(NearestPredicateTag,
  ^
1 error generated when compiling for sm_70.
examples/access_traits/CMakeFiles/ArborX_CudaAccessTraits.exe.dir/build.make:62: recipe for target 'examples/access_traits/CMakeFiles/ArborX_CudaAccessTraits.exe.dir/example_cuda_access_traits.cpp.o' failed
make[2]: *** [examples/access_traits/CMakeFiles/ArborX_CudaAccessTraits.exe.dir/example_cuda_access_traits.cpp.o] Error 1
make[2]: Leaving directory '/var/jenkins/workspace/ArborX_PR-271/build'
CMakeFiles/Makefile2:1836: recipe for target 'examples/access_traits/CMakeFiles/ArborX_CudaAccessTraits.exe.dir/all' failed
make[1]: *** [examples/access_traits/CMakeFiles/ArborX_CudaAccessTraits.exe.dir/all] Error 2

[sslattery]

Posting error message from Clang+CUDA build (which typically produce better error messages than NVCC)

I can confirm that these were the types of errors I saw in my first traits implementation - took a while to figure out.