Allow non device type template parameter for output views in query() on distributed trees #349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… distributed tree (spatial predicate only)
… distributed tree (nearest predicate)
…earchTreeImpl member functions
aprokop
reviewed
Jul 31, 2020
aprokop
approved these changes
Jul 31, 2020
Co-authored-by: Andrey Prokopenko <andrey.prok@gmail.com>
| typename Ranks> | ||
| static std::enable_if_t<Kokkos::is_view<Indices>{} && | ||
| Kokkos::is_view<Offset>{} && Kokkos::is_view<Ranks>{}> | ||
| queryDispatch(SpatialPredicateTag, DistributedTree const &tree, |
There was a problem hiding this comment.
Do you want to allow any other DistributedTree in this pull request?
Otherwise, I would rather use
Suggested change
| queryDispatch(SpatialPredicateTag, DistributedTree const &tree, | |
| queryDispatch(SpatialPredicateTag, DistributedSearchTree<MemorySpace, void> const &tree, |
(here and below).
There was a problem hiding this comment.
I wanted to get rid of the forward declaration. Also this is one less place to update if we add template parameters to the distributed tree.
| ExecutionSpace const &space, Predicates const &queries, | ||
| Kokkos::View<int *, DeviceType> &indices, | ||
| Kokkos::View<int *, DeviceType> &offset, | ||
| Kokkos::View<int *, DeviceType> &ranks) |
There was a problem hiding this comment.
We should probably also check that these views have the correct rank (here and below).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basically #271 but for distributed trees
Cleaning up distributed tree implementation details is more involved than anticipated.
My short term plan is to get all
queryDispatchoverloads out of the struct templated on the device type andthen to introduce the new overloads that take a view of "pair" local index + rank instead of two separate views.