Skip to content

Conversation

@haojin111
Copy link
Contributor

@haojin111 haojin111 commented Aug 3, 2021

Description

When apply cell background of table property, it should be applied to empty row's cells.

Fixes #2868

if no issue exists, please create an issue and ask the maintainers about this first

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please refer attached issue

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🔴 Total coverage has decreased
// Code coverage diff between base branch:release and head branch: FIX/2868-issue-of-adding-background-table 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 51.7 (0) 33.62 (-0.02) 29.55 (0) 52.35 (-0.01)
🔴 app/client/src/components/designSystems/appsmith/TableComponent/TableUtilities.tsx 38.02 (-0.96) 16.85 (-2.14) 9.38 (0) 36.04 (-1)

@haojin111 haojin111 requested a review from SatishGandham August 3, 2021 09:57
@haojin111 haojin111 requested a review from SatishGandham August 3, 2021 12:31
@haojin111 haojin111 requested a review from SatishGandham August 4, 2021 06:53
@somangshu somangshu requested a review from riodeuno August 26, 2021 12:58
@somangshu
Copy link
Contributor

somangshu commented Aug 26, 2021

Hey @riodeuno , Saw this was in the icebox and still got picked up. Can you please take a look at this to see if it looks right, I am not sure why this moved into the iceBox into the first place

@riodeuno
Copy link
Contributor

@somangshu This was reprioritised to a lower priority deferring to other issues, which were more critical at the time.
@haojin111 Thanks a lot for picking this up! The code looks fine to me. Tested this update on the deploy preview as well.

@somangshu somangshu merged commit 1021c18 into release Aug 30, 2021
@somangshu somangshu deleted the FIX/2868-issue-of-adding-background-table branch August 30, 2021 07:48
albinAppsmith pushed a commit that referenced this pull request Sep 8, 2021
* remove outermost quotes (#6938)

* This method removes the outermost quotes - single or double quotes - so that end users don't have to do it via javascript inside widget fields where they are meant to be bound.

* fix: Wrap JSON.stringify for text widget binding(suggested widgets) (#6651)

* Table widget: default selected row, 0th (#5930)

* added cell background of empty rows (#6353)

* added cell background of empty rows

* added tooltips for all the btns in comment card (#6952)

* updated button and link button as v2 design

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com>
Co-authored-by: Pranav Kanade <pranav@appsmith.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Background colour does not get added into the entire table

4 participants