Skip to content

Conversation

@pranavkanade
Copy link
Contributor

@pranavkanade pranavkanade commented Aug 30, 2021

Description

Added tooltips for - Reaction, Resolve thread and More options action buttons

Fixes #4994

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

  • Manual

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased
// Code coverage diff between base branch:release and head branch: fix/4994-show-tooltips-in-comment-cards 
Status File % Stmts % Branch % Funcs % Lines
🟢 total 54.93 (0.02) 36.81 (0) 33.59 (0.03) 55.46 (0)
🟢 app/client/src/comments/CommentCard/CommentContextMenu.tsx 80 (0.41) 81.82 (0) 33.33 (0) 80.85 (0.42)
🟢 app/client/src/comments/CommentCard/ResolveCommentButton.tsx 92.86 (0.55) 70 (0) 80 (0) 92.31 (0.64)
🟢 app/client/src/components/ads/EmojiPicker.tsx 86.96 (1.25) 100 (0) 33.33 (0) 85.71 (1.5)
🟢 app/client/src/constants/messages.ts 70.86 (0.41) 100 (0) 12.07 (1.23) 78.37 (0.22)
🔴 app/client/src/utils/autocomplete/TernServer.ts 50.47 (-0.24) 37.72 (-0.88) 36.21 (0) 55.08 (-0.27)

@pranavkanade pranavkanade changed the title fix: Show tooltips for action buttons in comment card Fix: Show tooltips for action buttons in comment card Aug 30, 2021
@pranavkanade pranavkanade changed the title Fix: Show tooltips for action buttons in comment card fix: show tooltips for action buttons in comment card Aug 30, 2021
@pranavkanade pranavkanade merged commit 47344bb into release Aug 30, 2021
@pranavkanade pranavkanade deleted the fix/4994-show-tooltips-in-comment-cards branch August 30, 2021 08:04
albinAppsmith pushed a commit that referenced this pull request Sep 8, 2021
* remove outermost quotes (#6938)

* This method removes the outermost quotes - single or double quotes - so that end users don't have to do it via javascript inside widget fields where they are meant to be bound.

* fix: Wrap JSON.stringify for text widget binding(suggested widgets) (#6651)

* Table widget: default selected row, 0th (#5930)

* added cell background of empty rows (#6353)

* added cell background of empty rows

* added tooltips for all the btns in comment card (#6952)

* updated button and link button as v2 design

Co-authored-by: Sumit Kumar <sumit@appsmith.com>
Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com>
Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com>
Co-authored-by: Pranav Kanade <pranav@appsmith.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]Collab->Toot tip should be display for the icon in the comments section

2 participants