Table widget: default selected row, 0th #5930

techbhavin · 2021-07-19T03:57:00Z

Description

Table widget: default selected row, 0th

Fixes #5892

Type of change

New feature (non-breaking change which adds functionality)

Checklist:

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
[] I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes

Test coverage results 🧪

🟢 Total coverage has increased

// Code coverage diff between base branch:release and head branch: feature/default-selected-row-zero

Status	File	% Stmts	% Branch	% Funcs	% Lines
🟢	total	55.1 (0.01)	37.01 (0.02)	33.8 (0.01)	55.7 (0.01)
🟢	app/client/src/utils/WidgetPropsUtils.tsx	74.55 (0.52)	66.47 (0.27)	69.89 (0.66)	73.57 (0.47)

somangshu

LGTM, @vivekverma2312 lets check if this caused any problem in old widgets, We will need to write migrations accordingly.

techbhavin · 2021-08-02T02:37:36Z

/ok-to-test sha= fa6c643

vivekverma2312 · 2021-08-02T07:40:58Z

@techbhavin Couple of observations:

Default selected row property is still showing as blank, if default value is 0 then we should also mention it in the property

By default row is not selected for old tables.

techbhavin · 2021-08-03T11:11:11Z

@somangshu @vivekverma2312

Point 1

There is an issue when propertyPane INPUT_TEXT type control has validation on Number. For default props and prop change from external source ( i.e. a btn click ) and new value of prop is "0" it is not reflected in propertyPane input field but new value of prop does reach out to component and it is updated as expected.

Point 2

we need to add migrations for this. let me add it

…lected-row-zero

techbhavin · 2021-08-04T06:14:09Z

/ok-to-test sha= 7deaf92

techbhavin · 2021-08-04T06:16:02Z

By default row is not selected for old tables.

@somangshu @vivekverma2312 migration test was added so please test point 2.

somangshu

Approving for the tests to run.

@marks0351 can you please verify the migrations?

vivekverma2312 · 2021-08-09T09:43:41Z

@techbhavin Migration issue is fixed and working fine. Issue 1 still exists.

marks0351 · 2021-08-10T08:06:36Z

@techbhavin defaultSelectedRowValidation is the validation that runs to evaluate. so this doesn't work because by default the evaluated value will be returned as 0 and a check in the input text control to check value truthness fails. so we need to return out strings instead of numbers in defaultSelectedRowValidation. this doesnot happen when the user types the input because it is always handled as strings. let me know if you want to discuss this.

…lected-row-zero

marks0351

Please do add cypress or jest test cases as well.

marks0351 · 2021-08-10T12:05:41Z

app/client/src/mockResponses/WidgetConfigResponse.tsx

    TABLE_WIDGET: {
      rows: 7 * GRID_DENSITY_MIGRATION_V1,
      columns: 9 * GRID_DENSITY_MIGRATION_V1,
+      defaultSelectedRow: "0" as any,


can u pls change the interface instead, wud help catch errors in other areas of code flow.

somangshu · 2021-08-13T07:04:32Z

Upon testing the deploy preview, I see that the old tables do not have the change. I think we should write migration for this as well if not already done. @marks0351 what is your thought?

The feature otherwise works well for the new tables and the above mentioned issues from the QA are fixed, Once we discuss the aforementioned point we can take this ahead

marks0351 · 2021-08-13T07:06:23Z

app/client/src/utils/WidgetPropsUtils.tsx

+  currentDSL: ContainerWidgetProps<WidgetProps>,
+) => {
+  if (currentDSL.type === WidgetTypes.TABLE_WIDGET) {
+    if (!currentDSL.defaultSelectedRow) currentDSL.defaultSelectedRow = 0;


can u change the zero to a string and check if the migration works?

somangshu · 2021-08-16T11:08:20Z

@techbhavin @marks0351 this still doesn't work of the older tables. Here is my app

marks0351 · 2021-08-16T11:14:46Z

@techbhavin @marks0351 this still doesn't work of the older tables. Here is my app

looks to be working for me. any chance you are using the same app as before to check this?

somangshu · 2021-08-16T11:17:40Z

@marks0351 its the same app as before, Should the old tables have default 0th key selected?

marks0351 · 2021-08-16T11:21:07Z

@marks0351 its the same app as before, Should the old tables have default 0th key selected?

by setting default selected row to 0, i thought that was what we are going for else there is no need for migration.
also if you are trying on the same app the old migration should have already run and this updated migration will not run on it, re create the app on release again and then check it on the dp if you wish to test.

somangshu · 2021-08-16T11:26:23Z

Thanks for the pro tip @marks0351, That worked!

somangshu

Approving for the tests to run

somangshu · 2021-08-17T12:55:27Z

@techbhavin can you resolve this conflict soon?

…lected-row-zero

somangshu · 2021-08-25T14:05:21Z

@techbhavin this issue is fixed, Can you please merge the latest release here?

…lected-row-zero

* storybook upgraded * button story added * Added button and radio story * added status package * merged release * AppIcon story added by Li * conflict fix * TextInput fixes by Li * Task/6744 updating stories (#6756) * update textinput story with rightsidecomponent * updated story of iconSelector component * updated menu story and added menu item story * Task/6744 updating stories (#6788) * update textinput story with rightsidecomponent * updated story of iconSelector component * updated menu story and added menu item story * updated story of search input * update textinput props and stories of table * removed unnecessary module * updated story of tabs component * feat: Updated stories of toast and tooltip (#6814) * update textinput story with rightsidecomponent * updated story of iconSelector component * updated menu story and added menu item story * updated story of search input * update textinput props and stories of table * removed unnecessary module * updated story of tabs component * updated story of text component * updated stories of toast and tooltip * removed commented code * Redux store configuration for storybook * Toast story UI fixes * fix: Storybook: tooltip ui fix (#6895) * update textinput story with rightsidecomponent * updated story of iconSelector component * updated menu story and added menu item story * updated story of search input * update textinput props and stories of table * removed unnecessary module * updated story of tabs component * updated story of text component * updated stories of toast and tooltip * removed commented code * fixed tooltip issue * fix: storybook - tooltip position fix (#6902) * update textinput story with rightsidecomponent * updated story of iconSelector component * updated menu story and added menu item story * updated story of search input * update textinput props and stories of table * removed unnecessary module * updated story of tabs component * updated story of text component * updated stories of toast and tooltip * removed commented code * fixed tooltip issue * updated story of tooltip component * fix: updated checkbox component as new design and dropdown conflict fix (#6920) * Add s3 support for generate CRUD (#6264) * Add s3 support for generate CRUD - Dropdown enhancement to open options on initial load - Hide column selection option for s3 * Refactor the prop name * Add useS3BucketList hook WIP * Dropdown enchancement & Fix small issues * Add fetch all sheets query * Add Query to get all S3 buckets * Fix dropdown open issue * Remove defaultIsOpen prop from dropdown * Resolve comments - Remove debugger - mockSheetUrl -> getSheetUrl * Add S3 cypress test * Fix cypress test yml config * Fix generate page cypress test * Remove onboarding typeform (#6752) * Update template application file to fix failing cypruss TC (#6758) * Add Gsheets support for generate CRUD page (#6301) * Add s3 support for generate CRUD - Dropdown enhancement to open options on initial load - Hide column selection option for s3 * Refactor the prop name * Dropdown enchancement & Fix small issues * Add fetch all sheets query * Fix issues related to dropdown * Add hooks to fetch sheets and spreadsheets * Resolve warnings * complete gheets basic support * Add UI changes for Gsheet column names - Fix Page Scroll issue * Add debounce to avoid to many API calls * Add request object formation via plugin config * Resolve comments & remove executingDatasourceQuery * Send sheetName in the tableName key. * Add loader and Column name UI Fix * Add Column Headers Label * Fix logic to show comma separator btn column names - Make "Column Header Fetched" text Bold * Add tooltip info for searchable column * Add value prop to TextInput - Fix Table header Index Invalid Input issue * Hotfix validator logic * Table UI test cases (#5910) * TableUITestCases Commit * Table-widget-testcases On Search Text Change Action Default array data On Row Selected Action Explore Widget related documents Verification On Page Change Action Default search text Default selected row Delete Table Widget Changing Column data type to "Image" Changing Column data type to "URL" Table Widget Functionality To Verify Row Height Functionality Drage and Drop Table widget and verify default data Table Widget Functionality To Filter The Data using 'Empty Table Widget Functionality To Filter The Data using 'Not Empty' * Discarded changes in cypress.json Discarded changes in cypress.json * Updated the test cases * Undo changes to Cypress.json Undo changes to Cypress.json * Added new dsl json file * Merge branch 'release' into SelectUITestCases * table test cases fix Co-authored-by: arslan <> * -allow login with case insensitive emails (#6712) * [Feature] - Add lastDeployedAt date to application object (#6753) * -add lastDeployedAt date to application object * -skip setting published date when application is forked * Fix: Style for documentation link in query pane (#6716) * updated styling for documentation link in query pane * added message constants * Expand all debugger errors by default (#6676) * Fix two skip tour options shown in onboarding (#6729) * fixed the filter issue in table widget (#6739) The filters did not get reset where the data in the table widget changes in the edit mode. This is now fixed * Added new type to the ActionConfig, fixed some typos (#6748) * [skip_changelog] Update error message for import flow (#6779) * Modified the error message for import version check, to make it more humane and actionable * Update TC * Fix/chart spec (#6774) * updated Chart spec with a wait for route * updated Chart spec with a wait for route * Commit page ui (#6772) * fixes in import/export feature cypress tests. Will also show a prompt to be able to choose the download location (#6767) * Analytics events for the comments onboarding (#6763) * Adding support for JSON object fields in Postgres for Prepared Statement (#6761) * Send errorType as part of analytics payload for action execution errors (#6754) * [Feature] Click on widget will no longer open property pane (#6219) * [Feature] Click on widget will no longer open property pane * fixing test cases * coverage fixes * fixing imports. * fixing build failure. * fixing new specs * clear property pane state for any new selection. * Filepicker v2 - Don't store large files in the dataStore (#6692) * - Create a clone of the existing filepicker widget * - If a file is larges than 5MB, don't put it in the dataTree. Co-authored-by: Satish Gandham <satish@appsmith.com> * menu style customization (#6237) - Menu widget needs to show transparent background - Make background none if user choose no background colour - Adopt button style options(menu style, variant, box shadow, border radius) * test: Added Support for MySQL (#6795) * Added Support for MySQL * Update setup-test.sh fixed sql file * Update setup-test.sh Fixed path * fix: Sentry type error in DB form (#6817) * FIX #6193 : bind enter and tab key on color picker input to close color board (#6305) This is done to improve the keyboard navigation on the property pane * feat: Widget grouping Extended Features (#6538) - [x] Draw to select from outside of the editor. - [x] Cmd + A to select child widgets inside containers, forms, list, tabs, and modals. Fixes #5995 Fixes #6102 * fix: Revert redux update perf improvements (#6808) * Fix: show property pane only when respective widget is present on the dom. (#6670) * [Enhancement] Adding Webpack bundle analyser for CRA, removing source map explorer for better visualisation. (#6793) * Enhancement: Adding better build visualiser(Webpack build analyser) * Feature flags snippet and linting features. (#6828) * Introduce feature flags for snippets feature and linting feature. * Feat: Style customisation in the button widget (#6052) Added multiple style props to the button widget: - Button styles - The background colour can change with a hex code - elevation (box-shadow & colour) - There are button variant contained (solid button), outlined (only borders), text (text buttons) - Button can have an end icon or start icon * fix: Api pane url input height and datasource mouse click. (#6818) * fix: Hide debugger errors until onPageLoadActions are run (#6786) * fix: Fix omnibar redirecting to invalid url when there are no results (#6696) * Grouping widgets into container (#5704) * Cut copy paste first cut * removed different parent groups logic * mouseup on the outer canvas removes selections. * bug fix * remove unwanted dead code. * Adding tests * build fix * min height fixes * fixing specs. * fixing specs. * fix merge conflcits * fix border positioning * fix canvas widgets incorrect bouding box * fix bounding box position issue * fix bounding box position issue * fix * border issue fix * update test case * add colors in theme * use layers + use click capture on actions * add icon for grouping * fix overflow issue in contextmenu in containers * fix context menu display issue * update position of context menu * fix container box-shadow issue * fix container box-shadow issue * revert container box shadow * stop opening of property pane on shift clicking a widget * remove console.log * fix multiselect box issue * add container on copy * add analytics middleware * refactor paste widget saga * change flash element to accept array + revert refactor * add logic to create containers from selected widgets * update positions of grouped widgets * fix comments + remove console * update flashElementbyId to flashElementsById * remove analytics middleware + remove unecessary imports * add shorcut for grouping * fix position issue when pasting * allow grouping only when multi widgets are selected * fix ux issues with widget grouping * fix help text for grouping actions * filter out the modal widget when calculting next row * fix delete issue when grouping * persist positin when grouping if there is no collision * fix typo for new position * changes for review comments * changes for review comments * fix position issue when pasting * fix new container position issue * move utils function to utils * fix import issue * fix the composite widget grouping issue * fix table name bug * remove repeated code * move copied groups existence check; * fix copied group check Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local> * fix: Generate Page using Empty Table error (#6834) - Do not allow to generate CRUD app when selected table of datasource is empty (has no columns) - Fix #6824: When the Dropdown is empty (has no options) do not show the dropdown option (popup) UI. * fix: load main container without waiting for evaluations to complete. (#6669) * Fix: load main container without waiting for evaluations to complete. * -improved logging in RTS (#6846) * fix: List Item de-selection and empty state on deploy mode (#6871) * revert deselection * fix empty list state page mode Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> * - change action editor field label (#6845) * The input box label in the Firestore plugin action editor reads Document / Collection Path which is misleading since a document is nested inside a collection and not the other way round. Hence changing it to Collection / Document Path * fix: inclusion of authorization error for Google sheets (#6674) * Added authorisation status to Google sheet datasource form * fix: chart widget fix (#6867) Custom fusion chart was loading with some delay and cypress test cases were getting previous element to verify the x axis data. Added one more check to wait till the chart data is loaded before verifying. * fix: tab component styles for the dark theme (#6833) * feat: add merge page ui (#6836) * fix: improving multipart form data body (#6755) * improved multipart form data body * docs: add somangshu as a contributor for bug, code (#6821) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * feat: add feature flag for multiplayer feature (#6878) * fix: Restrict e as valid number input (#6866) Restrict e for table header index value and allow only whole numbers * Table sort column APIs (#6068) User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event * test: CypressNewVersion (#6116) * Upgrade Cypress Version * Upgrade to 7.6 * update moment library with Dayjs * updated a test * Added tests for copy to clipboard * Added a missing dsl * Fix/select widget placeholder (#6677) * fix: add placeholder to select widget * fix: consistency between select / multi-select widgets * FIX: table widget updated page count on enter key press in pagination input (#6196) * Fix: RTE crash on defaultText change (#6789) * feat: Add maven module for the git operations (#6825) * Add appsmith-git maven module for all the git related operations * Add form data support for superuser signup API (#6844) The superuser signup api available at /users/super currently only supports JSON payload. This PR adds support for form-data payload at the same endpoint, and makes it consistent with the normal user's signup API endpoint. * fix: Do not mark property pane field as an error when the field is empty. * feat: show lint errors in code editor (#6265) * feat: Changing evaluations for UQI from hidden type to js objects (#6792) * Added a new type of UIComponent for DB editor forms * Added a new state for UQI evals and connected it to the rendering form * Added sagas to init and run the UQI eval * Exporting fetch function as a selector * Moved selector code to the formSelector file * Added type to state config holder, removed custom diff function and fixed imports * Fixed path, added the type for plugin in selector * Created new enum, abstracted function for render and fixed var names Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com> * ci: Fix large documents breaking upload to Algolia (#6815) When uploading docs to Algolia, if the document's JSON representation is larger than 10KB (roughly), then Algolia API will reject it. * docs: Update server Readme for new Intellij IDEA version (#5576) Co-authored-by: Ali Zahir <Ali> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> * feat: add multiplayer feature flag (#6888) * updated feature flag to type * added feature flag dependency for pointer sharing and editor listing features * chore: Deleting redundant Dockerfile for Cypress (#5683) Co-authored-by: Arpit Mohan <arpit@appsmith.com> * feat: Show Crud Info Modal data from backend (#6882) CRUD Info modal which pops up on successful CRUD generation, will now have dynamic data for each CRUD template. Modal success `message` and `Image` to explain the working of the CRUD template is fetched from the backend. Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM> * fix: Show button when fetching columns (#6891) Improve UX when entering `Table Header Index` value BEFORE: Generate Template Button was hidden when the new column header is getting fetched. There was no loader for a user to understand that data is being fetched. NOW: Generate Template Button is always visible and goes in a loading state when user data is being fetched. * fix: null check for current application while handling create new thread event (#6881) * fix: flashing cursor not shown on inputbox when sign-in details are picked from saved credentials (#6776) * feat: Update the conditional for section components for UQI (#6896) * fix: Fix canvas in bigger containers. (#6849) * Enhancement - chart widget x-axis label orientation (#6708) * Chart widget - x-axis label orientation selector * added test cases * minor typing fix * renamed CustomChartConstants -> ChartConstants, moved ChartComponents constants to ChartConstants * Input widget: New data type supported - Phone number with ISD codes (#5256) * test: Form widget UI test (#6884) * Form widget test cases * Form widget Test Cases - Form widget fixes * Form widget Test Cases Defult Form text, Reset and Close button Validation Add Multiple widgets in Form Form_Widget Minimize and maximize General Validation Rename Form widget from Entity Explorer Toggle JS - Form-Unckeck Visible field Validationpassed Toggle JS - Form-Check Visible field Validationpassed Copy Paste Validation Form Delete Validation * Form_test_cases_Fix * Form test cases fix * docs: add akshayrangasaid as a contributor for content, ideas (#6911) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * updated checkbox component as new design * fix: fill dropdown option avoiding text shrink (#6910) Fix text shirking of the dropdown selector * updated story of toast component Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com> Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com> Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com> Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com> Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com> Co-authored-by: Pranav Kanade <pranav@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com> Co-authored-by: Ayush Pahwa <ayushpahwa96@gmail.com> Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com> Co-authored-by: Trisha Anand <trisha@appsmith.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> Co-authored-by: Satish Gandham <satish@appsmith.com> Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com> Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com> Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com> Co-authored-by: Hetu Nandu <hetunandu@gmail.com> Co-authored-by: Sumit Kumar <sumit@appsmith.com> Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local> Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com> Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com> Co-authored-by: ashit-rath <88306433+ashit-rath@users.noreply.github.com> Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com> Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com> Co-authored-by: Ali <39810925+alzaar@users.noreply.github.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> Co-authored-by: Snyk bot <snyk-bot@snyk.io> Co-authored-by: Arpit Mohan <arpit@appsmith.com> Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM> Co-authored-by: Yash Siddharth Bhange <60029585+Yash-Bhange@users.noreply.github.com> * Task/6898 (#6926) * Add s3 support for generate CRUD (#6264) * Add s3 support for generate CRUD - Dropdown enhancement to open options on initial load - Hide column selection option for s3 * Refactor the prop name * Add useS3BucketList hook WIP * Dropdown enchancement & Fix small issues * Add fetch all sheets query * Add Query to get all S3 buckets * Fix dropdown open issue * Remove defaultIsOpen prop from dropdown * Resolve comments - Remove debugger - mockSheetUrl -> getSheetUrl * Add S3 cypress test * Fix cypress test yml config * Fix generate page cypress test * Remove onboarding typeform (#6752) * Update template application file to fix failing cypruss TC (#6758) * Add Gsheets support for generate CRUD page (#6301) * Add s3 support for generate CRUD - Dropdown enhancement to open options on initial load - Hide column selection option for s3 * Refactor the prop name * Dropdown enchancement & Fix small issues * Add fetch all sheets query * Fix issues related to dropdown * Add hooks to fetch sheets and spreadsheets * Resolve warnings * complete gheets basic support * Add UI changes for Gsheet column names - Fix Page Scroll issue * Add debounce to avoid to many API calls * Add request object formation via plugin config * Resolve comments & remove executingDatasourceQuery * Send sheetName in the tableName key. * Add loader and Column name UI Fix * Add Column Headers Label * Fix logic to show comma separator btn column names - Make "Column Header Fetched" text Bold * Add tooltip info for searchable column * Add value prop to TextInput - Fix Table header Index Invalid Input issue * Hotfix validator logic * Table UI test cases (#5910) * TableUITestCases Commit * Table-widget-testcases On Search Text Change Action Default array data On Row Selected Action Explore Widget related documents Verification On Page Change Action Default search text Default selected row Delete Table Widget Changing Column data type to "Image" Changing Column data type to "URL" Table Widget Functionality To Verify Row Height Functionality Drage and Drop Table widget and verify default data Table Widget Functionality To Filter The Data using 'Empty Table Widget Functionality To Filter The Data using 'Not Empty' * Discarded changes in cypress.json Discarded changes in cypress.json * Updated the test cases * Undo changes to Cypress.json Undo changes to Cypress.json * Added new dsl json file * Merge branch 'release' into SelectUITestCases * table test cases fix Co-authored-by: arslan <> * -allow login with case insensitive emails (#6712) * [Feature] - Add lastDeployedAt date to application object (#6753) * -add lastDeployedAt date to application object * -skip setting published date when application is forked * Fix: Style for documentation link in query pane (#6716) * updated styling for documentation link in query pane * added message constants * Expand all debugger errors by default (#6676) * Fix two skip tour options shown in onboarding (#6729) * fixed the filter issue in table widget (#6739) The filters did not get reset where the data in the table widget changes in the edit mode. This is now fixed * Added new type to the ActionConfig, fixed some typos (#6748) * [skip_changelog] Update error message for import flow (#6779) * Modified the error message for import version check, to make it more humane and actionable * Update TC * Fix/chart spec (#6774) * updated Chart spec with a wait for route * updated Chart spec with a wait for route * Commit page ui (#6772) * fixes in import/export feature cypress tests. Will also show a prompt to be able to choose the download location (#6767) * Analytics events for the comments onboarding (#6763) * Adding support for JSON object fields in Postgres for Prepared Statement (#6761) * Send errorType as part of analytics payload for action execution errors (#6754) * [Feature] Click on widget will no longer open property pane (#6219) * [Feature] Click on widget will no longer open property pane * fixing test cases * coverage fixes * fixing imports. * fixing build failure. * fixing new specs * clear property pane state for any new selection. * Filepicker v2 - Don't store large files in the dataStore (#6692) * - Create a clone of the existing filepicker widget * - If a file is larges than 5MB, don't put it in the dataTree. Co-authored-by: Satish Gandham <satish@appsmith.com> * menu style customization (#6237) - Menu widget needs to show transparent background - Make background none if user choose no background colour - Adopt button style options(menu style, variant, box shadow, border radius) * test: Added Support for MySQL (#6795) * Added Support for MySQL * Update setup-test.sh fixed sql file * Update setup-test.sh Fixed path * fix: Sentry type error in DB form (#6817) * FIX #6193 : bind enter and tab key on color picker input to close color board (#6305) This is done to improve the keyboard navigation on the property pane * feat: Widget grouping Extended Features (#6538) - [x] Draw to select from outside of the editor. - [x] Cmd + A to select child widgets inside containers, forms, list, tabs, and modals. Fixes #5995 Fixes #6102 * fix: Revert redux update perf improvements (#6808) * Fix: show property pane only when respective widget is present on the dom. (#6670) * [Enhancement] Adding Webpack bundle analyser for CRA, removing source map explorer for better visualisation. (#6793) * Enhancement: Adding better build visualiser(Webpack build analyser) * Feature flags snippet and linting features. (#6828) * Introduce feature flags for snippets feature and linting feature. * Feat: Style customisation in the button widget (#6052) Added multiple style props to the button widget: - Button styles - The background colour can change with a hex code - elevation (box-shadow & colour) - There are button variant contained (solid button), outlined (only borders), text (text buttons) - Button can have an end icon or start icon * fix: Api pane url input height and datasource mouse click. (#6818) * fix: Hide debugger errors until onPageLoadActions are run (#6786) * fix: Fix omnibar redirecting to invalid url when there are no results (#6696) * Grouping widgets into container (#5704) * Cut copy paste first cut * removed different parent groups logic * mouseup on the outer canvas removes selections. * bug fix * remove unwanted dead code. * Adding tests * build fix * min height fixes * fixing specs. * fixing specs. * fix merge conflcits * fix border positioning * fix canvas widgets incorrect bouding box * fix bounding box position issue * fix bounding box position issue * fix * border issue fix * update test case * add colors in theme * use layers + use click capture on actions * add icon for grouping * fix overflow issue in contextmenu in containers * fix context menu display issue * update position of context menu * fix container box-shadow issue * fix container box-shadow issue * revert container box shadow * stop opening of property pane on shift clicking a widget * remove console.log * fix multiselect box issue * add container on copy * add analytics middleware * refactor paste widget saga * change flash element to accept array + revert refactor * add logic to create containers from selected widgets * update positions of grouped widgets * fix comments + remove console * update flashElementbyId to flashElementsById * remove analytics middleware + remove unecessary imports * add shorcut for grouping * fix position issue when pasting * allow grouping only when multi widgets are selected * fix ux issues with widget grouping * fix help text for grouping actions * filter out the modal widget when calculting next row * fix delete issue when grouping * persist positin when grouping if there is no collision * fix typo for new position * changes for review comments * changes for review comments * fix position issue when pasting * fix new container position issue * move utils function to utils * fix import issue * fix the composite widget grouping issue * fix table name bug * remove repeated code * move copied groups existence check; * fix copied group check Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local> * fix: Generate Page using Empty Table error (#6834) - Do not allow to generate CRUD app when selected table of datasource is empty (has no columns) - Fix #6824: When the Dropdown is empty (has no options) do not show the dropdown option (popup) UI. * fix: load main container without waiting for evaluations to complete. (#6669) * Fix: load main container without waiting for evaluations to complete. * -improved logging in RTS (#6846) * fix: List Item de-selection and empty state on deploy mode (#6871) * revert deselection * fix empty list state page mode Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> * - change action editor field label (#6845) * The input box label in the Firestore plugin action editor reads Document / Collection Path which is misleading since a document is nested inside a collection and not the other way round. Hence changing it to Collection / Document Path * fix: inclusion of authorization error for Google sheets (#6674) * Added authorisation status to Google sheet datasource form * fix: chart widget fix (#6867) Custom fusion chart was loading with some delay and cypress test cases were getting previous element to verify the x axis data. Added one more check to wait till the chart data is loaded before verifying. * fix: tab component styles for the dark theme (#6833) * feat: add merge page ui (#6836) * fix: improving multipart form data body (#6755) * improved multipart form data body * docs: add somangshu as a contributor for bug, code (#6821) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * feat: add feature flag for multiplayer feature (#6878) * fix: Restrict e as valid number input (#6866) Restrict e for table header index value and allow only whole numbers * Table sort column APIs (#6068) User now should have access to the table sort column if any through the `{{table.sortOrder}}` API. This will return an object when sort is active > {column: string, order: enum|‘asc’|'desc'}. There should also be a `onSort` action available which can trigger an Event * test: CypressNewVersion (#6116) * Upgrade Cypress Version * Upgrade to 7.6 * update moment library with Dayjs * updated a test * Added tests for copy to clipboard * Added a missing dsl * Fix/select widget placeholder (#6677) * fix: add placeholder to select widget * fix: consistency between select / multi-select widgets * FIX: table widget updated page count on enter key press in pagination input (#6196) * Fix: RTE crash on defaultText change (#6789) * feat: Add maven module for the git operations (#6825) * Add appsmith-git maven module for all the git related operations * Add form data support for superuser signup API (#6844) The superuser signup api available at /users/super currently only supports JSON payload. This PR adds support for form-data payload at the same endpoint, and makes it consistent with the normal user's signup API endpoint. * fix: Do not mark property pane field as an error when the field is empty. * feat: show lint errors in code editor (#6265) * feat: Changing evaluations for UQI from hidden type to js objects (#6792) * Added a new type of UIComponent for DB editor forms * Added a new state for UQI evals and connected it to the rendering form * Added sagas to init and run the UQI eval * Exporting fetch function as a selector * Moved selector code to the formSelector file * Added type to state config holder, removed custom diff function and fixed imports * Fixed path, added the type for plugin in selector * Created new enum, abstracted function for render and fixed var names Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com> * ci: Fix large documents breaking upload to Algolia (#6815) When uploading docs to Algolia, if the document's JSON representation is larger than 10KB (roughly), then Algolia API will reject it. * docs: Update server Readme for new Intellij IDEA version (#5576) Co-authored-by: Ali Zahir <Ali> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> * feat: add multiplayer feature flag (#6888) * updated feature flag to type * added feature flag dependency for pointer sharing and editor listing features * chore: Deleting redundant Dockerfile for Cypress (#5683) Co-authored-by: Arpit Mohan <arpit@appsmith.com> * feat: Show Crud Info Modal data from backend (#6882) CRUD Info modal which pops up on successful CRUD generation, will now have dynamic data for each CRUD template. Modal success `message` and `Image` to explain the working of the CRUD template is fetched from the backend. Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM> * fix: Show button when fetching columns (#6891) Improve UX when entering `Table Header Index` value BEFORE: Generate Template Button was hidden when the new column header is getting fetched. There was no loader for a user to understand that data is being fetched. NOW: Generate Template Button is always visible and goes in a loading state when user data is being fetched. * fix: null check for current application while handling create new thread event (#6881) * fix: flashing cursor not shown on inputbox when sign-in details are picked from saved credentials (#6776) * feat: Update the conditional for section components for UQI (#6896) * fix: Fix canvas in bigger containers. (#6849) * Enhancement - chart widget x-axis label orientation (#6708) * Chart widget - x-axis label orientation selector * added test cases * minor typing fix * renamed CustomChartConstants -> ChartConstants, moved ChartComponents constants to ChartConstants * Input widget: New data type supported - Phone number with ISD codes (#5256) * test: Form widget UI test (#6884) * Form widget test cases * Form widget Test Cases - Form widget fixes * Form widget Test Cases Defult Form text, Reset and Close button Validation Add Multiple widgets in Form Form_Widget Minimize and maximize General Validation Rename Form widget from Entity Explorer Toggle JS - Form-Unckeck Visible field Validationpassed Toggle JS - Form-Check Visible field Validationpassed Copy Paste Validation Form Delete Validation * Form_test_cases_Fix * Form test cases fix * docs: add akshayrangasaid as a contributor for content, ideas (#6911) * docs: update README.md [skip ci] * docs: update .all-contributorsrc [skip ci] Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> * updated checkbox component as new design * fix: fill dropdown option avoiding text shrink (#6910) Fix text shirking of the dropdown selector * updated story of toast component * removed unnecessary part Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com> Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com> Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com> Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com> Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com> Co-authored-by: Pranav Kanade <pranav@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com> Co-authored-by: Ayush Pahwa <ayushpahwa96@gmail.com> Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com> Co-authored-by: Trisha Anand <trisha@appsmith.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> Co-authored-by: Satish Gandham <satish@appsmith.com> Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com> Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com> Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com> Co-authored-by: Hetu Nandu <hetunandu@gmail.com> Co-authored-by: Sumit Kumar <sumit@appsmith.com> Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local> Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com> Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com> Co-authored-by: ashit-rath <88306433+ashit-rath@users.noreply.github.com> Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com> Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com> Co-authored-by: Ali <39810925+alzaar@users.noreply.github.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> Co-authored-by: Snyk bot <snyk-bot@snyk.io> Co-authored-by: Arpit Mohan <arpit@appsmith.com> Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM> Co-authored-by: Yash Siddharth Bhange <60029585+Yash-Bhange@users.noreply.github.com> * Removed unnecessary Helpertext component * remove outermost quotes (#6938) * This method removes the outermost quotes - single or double quotes - so that end users don't have to do it via javascript inside widget fields where they are meant to be bound. * fix: Wrap JSON.stringify for text widget binding(suggested widgets) (#6651) * Table widget: default selected row, 0th (#5930) Co-authored-by: haojin111 <63215848+haojin111@users.noreply.github.com> Co-authored-by: Rishabh Rathod <rishabh.rathod@appsmith.com> Co-authored-by: Rishabh Saxena <rishabh.robben@gmail.com> Co-authored-by: Abhijeet <41686026+abhvsn@users.noreply.github.com> Co-authored-by: arslanhaiderbuttar <83570904+arslanhaiderbuttar@users.noreply.github.com> Co-authored-by: Nayan <83352306+nayan-rafiq@users.noreply.github.com> Co-authored-by: Pranav Kanade <pranav@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Yash Vibhandik <vibhandikyash@gmail.com> Co-authored-by: Ayush Pahwa <ayushpahwa96@gmail.com> Co-authored-by: NandanAnantharamu <67676905+NandanAnantharamu@users.noreply.github.com> Co-authored-by: Trisha Anand <trisha@appsmith.com> Co-authored-by: Ashok Kumar M <35134347+marks0351@users.noreply.github.com> Co-authored-by: Satish Gandham <satish.iitg@gmail.com> Co-authored-by: Satish Gandham <satish@appsmith.com> Co-authored-by: Paul Li <82799722+wmdev0808@users.noreply.github.com> Co-authored-by: yatinappsmith <84702014+yatinappsmith@users.noreply.github.com> Co-authored-by: arunvjn <32433245+arunvjn@users.noreply.github.com> Co-authored-by: Hetu Nandu <hetunandu@gmail.com> Co-authored-by: Sumit Kumar <sumit@appsmith.com> Co-authored-by: Pawan Kumar <pawan.stardust@gmail.com> Co-authored-by: root <root@DESKTOP-9GENCK0.localdomain> Co-authored-by: Pawan Kumar <pawankumar@Pawans-MacBook-Pro.local> Co-authored-by: Favour Ohanekwu <fohanekwu@gmail.com> Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com> Co-authored-by: Vicky Bansal <67091118+vicky-primathon@users.noreply.github.com> Co-authored-by: Tolulope Adetula <31691737+Tooluloope@users.noreply.github.com> Co-authored-by: ashit-rath <88306433+ashit-rath@users.noreply.github.com> Co-authored-by: Anagh Hegde <anagh@appsmith.com> Co-authored-by: Shrikant Sharat Kandula <shrikant@appsmith.com> Co-authored-by: Vinod <4994565+vnodecg@users.noreply.github.com> Co-authored-by: Apeksha Bhosale <7846888+ApekshaBhosale@users.noreply.github.com> Co-authored-by: Ali <39810925+alzaar@users.noreply.github.com> Co-authored-by: Arpit Mohan <mohanarpit@users.noreply.github.com> Co-authored-by: Snyk bot <snyk-bot@snyk.io> Co-authored-by: Arpit Mohan <arpit@appsmith.com> Co-authored-by: Abhijeet <ABHI.NAGARNAIK@GMAIL.COM> Co-authored-by: Yash Siddharth Bhange <60029585+Yash-Bhange@users.noreply.github.com> Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com>

* remove outermost quotes (#6938) * This method removes the outermost quotes - single or double quotes - so that end users don't have to do it via javascript inside widget fields where they are meant to be bound. * fix: Wrap JSON.stringify for text widget binding(suggested widgets) (#6651) * Table widget: default selected row, 0th (#5930) * added cell background of empty rows (#6353) * added cell background of empty rows * added tooltips for all the btns in comment card (#6952) * updated button and link button as v2 design Co-authored-by: Sumit Kumar <sumit@appsmith.com> Co-authored-by: akash-codemonk <67054171+akash-codemonk@users.noreply.github.com> Co-authored-by: Bhavin K <58818598+techbhavin@users.noreply.github.com> Co-authored-by: Pranav Kanade <pranav@appsmith.com>

set defaultSelectedRow prop of table 0

fa6c643

techbhavin added the new-contribution label Jul 19, 2021

techbhavin requested a review from somangshu July 19, 2021 03:57

somangshu previously approved these changes Jul 19, 2021

View reviewed changes

techbhavin added the UI Building Pod label Jul 20, 2021

techbhavin added 2 commits August 3, 2021 18:01

Merge remote-tracking branch 'origin/release' into feature/default-se…

d55c4f0

…lected-row-zero

added migration script

7deaf92

techbhavin dismissed somangshu’s stale review via 7deaf92 August 4, 2021 06:13

techbhavin requested review from somangshu and vivekverma2312 August 4, 2021 06:14

somangshu removed the request for review from vivekverma2312 August 4, 2021 06:24

somangshu previously approved these changes Aug 4, 2021

View reviewed changes

somangshu requested a review from marks0351 August 4, 2021 06:26

marks0351 previously approved these changes Aug 4, 2021

View reviewed changes

number prop changed to string

6c38505

techbhavin dismissed stale reviews from marks0351 and somangshu via 6c38505 August 10, 2021 11:49

techbhavin requested a review from marks0351 August 10, 2021 11:49

Merge remote-tracking branch 'origin/release' into feature/default-se…

d14a9e0

…lected-row-zero

marks0351 suggested changes Aug 10, 2021

View reviewed changes

defaultSelectedRow interface added string type

3a046f7

techbhavin requested a review from marks0351 August 11, 2021 11:31

marks0351 approved these changes Aug 13, 2021

View reviewed changes

marks0351 suggested changes Aug 13, 2021

View reviewed changes

migration updated

acc8431

techbhavin requested review from marks0351 and somangshu August 13, 2021 10:02

somangshu removed their request for review August 16, 2021 11:08

somangshu previously approved these changes Aug 16, 2021

View reviewed changes

marks0351 previously approved these changes Aug 17, 2021

View reviewed changes

Merge remote-tracking branch 'origin/release' into feature/default-se…

2bb45db

…lected-row-zero

techbhavin dismissed stale reviews from marks0351 and somangshu via 2bb45db August 18, 2021 05:33

Merge branch 'release' into feature/default-selected-row-zero

e2c62b6

somangshu previously approved these changes Aug 18, 2021

View reviewed changes

Merge remote-tracking branch 'origin/release' into feature/default-se…

adcaebb

…lected-row-zero

techbhavin dismissed somangshu’s stale review via adcaebb August 18, 2021 11:39

somangshu approved these changes Aug 20, 2021

View reviewed changes

Merge remote-tracking branch 'origin/release' into feature/default-se…

dbc3f8d

…lected-row-zero

somangshu approved these changes Aug 28, 2021

View reviewed changes

somangshu merged commit b892712 into release Aug 30, 2021

somangshu deleted the feature/default-selected-row-zero branch August 30, 2021 06:58

Table widget: default selected row, 0th #5930

Table widget: default selected row, 0th #5930

Uh oh!

Conversation

techbhavin commented Jul 19, 2021 • edited by github-actions bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of change

Checklist:

Test coverage results 🧪

Uh oh!

somangshu left a comment

Choose a reason for hiding this comment

Uh oh!

techbhavin commented Aug 2, 2021

Uh oh!

vivekverma2312 commented Aug 2, 2021

Uh oh!

techbhavin commented Aug 3, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

techbhavin commented Aug 4, 2021

Uh oh!

techbhavin commented Aug 4, 2021

Uh oh!

somangshu left a comment

Choose a reason for hiding this comment

Uh oh!

vivekverma2312 commented Aug 9, 2021

Uh oh!

marks0351 commented Aug 10, 2021

Uh oh!

marks0351 left a comment

Choose a reason for hiding this comment

Uh oh!

marks0351 Aug 10, 2021

Choose a reason for hiding this comment

Uh oh!

somangshu commented Aug 13, 2021

Uh oh!

marks0351 Aug 13, 2021

Choose a reason for hiding this comment

Uh oh!

somangshu commented Aug 16, 2021

Uh oh!

marks0351 commented Aug 16, 2021

Uh oh!

somangshu commented Aug 16, 2021

Uh oh!

marks0351 commented Aug 16, 2021

Uh oh!

somangshu commented Aug 16, 2021

Uh oh!

somangshu left a comment

Choose a reason for hiding this comment

Uh oh!

somangshu commented Aug 17, 2021

Uh oh!

somangshu commented Aug 25, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

techbhavin commented Jul 19, 2021 •

edited by github-actions bot

Loading

techbhavin commented Aug 3, 2021 •

edited

Loading