-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/draggable filters in table widget #5886
Feature/draggable filters in table widget #5886
Conversation
… support in popper
…able-filterpane-in-table-widget
…able-filterpane-in-table-widget
…able-filterpane-in-table-widget
…ithub.com:appsmithorg/appsmith into FEATURE/4088-draggable-filterpane-in-table-widget
…able-filterpane-in-table-widget
…o FEATURE/4088-draggable-filterpane-in-table-widget
/ok-to-test sha=273523e |
/ok-to-test sha=5497db7 |
1 similar comment
/ok-to-test sha=5497db7 |
/ok-to-test sha=3114078 |
@vicky-primathon please merge latest release here, We have a few fixes available |
…o feature/draggable-filters-in-table-widget
@somangshu @somangshu @vibhandikyash Verified the fixes and the following issues are working as expected [Bug] Deploy Preview - Table Widget - Once when the filter is applied again user needs to click on filter icon for using other filter #5329 - Verified For the above table data use the following sample api and bind with the table data - https://reqres.in/api/users?page=2 https://loom.com/share/1514c5e725b343c290e65b82cd478f6c 6)Can we have clear button inside the filter pane so that without removing the existing filter user can clear the data |
@YogeshJayaseelan Issue 5 is fixed. |
@vicky-primathon @YogeshJayaseelan while I agree the option to clear all filter is great, I think we should take that up as a separate requirement. @YogeshJayaseelan please raise an enhancement for this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Runnning tests
@somangshu @vicky-primathon Rested the fixes and they are working as expected. Issues Fixed: Raised Separate Enhancement for 'Clear' option |
Description
User should be able to drag the filter pane on the table widget anywhere on the canvas, just like how user can do with the property pane.
Fixes #4088
Fixes #5329
Fixes #5332
Type of change
How Has This Been Tested?
Checklist:
Test coverage results 🧪
🟢 Total coverage has increased