Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Deploy Preview - Table Widget - Once when the filter is applied again user needs to click on filter icon for using other filter #5329

Closed
YogeshJayaseelan opened this issue Jun 22, 2021 · 1 comment · Fixed by #5886
Closed

[Bug] Deploy Preview - Table Widget - Once when the filter is applied again user needs to click on filter icon for using other filter #5329

YogeshJayaseelan opened this issue Jun 22, 2021 · 1 comment · Fixed by #5886
Assignees
@vibhandikyash
Labels
Bug Something isn't working Deploy Preview Issues found in Deploy Preview Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Table Widget Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets

Comments

@YogeshJayaseelan
Copy link
Contributor

YogeshJayaseelan commented Jun 22, 2021 •
edited by loom-gif-previews bot
Loading

Description

Deploy Preview - https://deploy-preview-5257--appsmith-editor-ce.netlify.app/

Table Widget - It is observed that once when the filter is applied user needs to click on filter icon again to perform other filters

Expected Result:
Can we have a close button in the filter pane so that user can close filter manually or any appropriate behaviour

Actual Result:
User needs to click on filter icon each and every time for performing filter once when the filter is applied

Steps to reproduce the behaviour:

  1. Launch appmith app in the Deploy Preview https://deploy-preview-5257--appsmith-editor-ce.netlify.app/
  2. Drag and Drop Table widget
  3. Click on filter option
  4. Filter pane will be displayed and filter anything and click on apply filter and observe filter pane closes

Video Link:
LOOM DEMO

Important Details

  • Version: [14.1 (16611.1.21.161.3)]
  • OS: [MacOS]
  • Browser [chrome, safari]
  • Environment [deploy preview]
@YogeshJayaseelan YogeshJayaseelan added Bug Something isn't working Table Widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Deploy Preview Issues found in Deploy Preview labels Jun 22, 2021
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Jun 22, 2021
@YogeshJayaseelan YogeshJayaseelan mentioned this issue Jun 22, 2021
Closed
7 tasks
vibhandikyash added a commit that referenced this issue Jun 25, 2021
@vibhandikyash
FIX #5329: added close button for close filter pane
adf530b
@somangshu
Copy link
Contributor

note:

  • Clicking outside should close the filter pane
  • Clicking apply should keep the pane open

@vicky-primathon vicky-primathon mentioned this issue Jul 15, 2021
Merged
7 tasks
somangshu pushed a commit that referenced this issue Jul 20, 2021
@vicky-primathon
Feature/draggable filters in table widget (#5886)
6f91c1a 
The filter pane in the table widget was fixed to top which would hinder the viewport for the end user. We have now changed the filter pane to a draggable component such that the user can place it anywhere on the canvas while they apply filters to see data change in realtime.

* FEATURE #4088 : added draggable filterpane for table widget

* FEATURE #4088 : update icons, editMode prop and added renderDragBlock support in popper

* FIX #5329: added close button for close filter pane

* FIX #5332 : updated zindex for table filter pane

* fix list widget test

* Fix drag icon position and cypress failing tests

* Fix endsWidth comparator function
@close-label close-label bot added the QA Needs QA attention label Jul 20, 2021
@YogeshJayaseelan YogeshJayaseelan added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Jul 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhandikyash vibhandikyash

Labels
Bug Something isn't working Deploy Preview Issues found in Deploy Preview Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Table Widget Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
4 participants
@Nikhil-Nandagopal @somangshu @vibhandikyash @YogeshJayaseelan