Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] Table Widget Filter Pane - clear button to remove all filter #5980

Closed
YogeshJayaseelan opened this issue Jul 20, 2021 · 5 comments · Fixed by #8734
Closed

[Enhancement] Table Widget Filter Pane - clear button to remove all filter #5980

YogeshJayaseelan opened this issue Jul 20, 2021 · 5 comments · Fixed by #8734
Assignees
@vibhandikyash
Labels
Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Table Widget Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets

Comments

@YogeshJayaseelan
Copy link
Contributor

YogeshJayaseelan commented Jul 20, 2021 •
edited by momcilo-appsmith
Loading

Description

Deploy Preview - #5886
Table Widget - Filter pane - Suggestion to have clear button in the filter pane so that the user can clear applied filters without removing the applied filters.

Steps to reproduce the behaviour:

1.Launch Appmsith app in the Deploy Preview - #5886
2.Drag and Drop Table Widget
3.Open filter pane
4.Apply any filter and check there is no option to clear applied filter

Important Details

  • Version: [11.3 ]
  • OS: [MacOS Big Sur]
  • Browser [chrome, safari]
  • Environment [

Screenshot 2021-07-20 at 9 30 12 AM

deploy preview]

Figma Designs Link

New modal design: https://www.figma.com/file/trkiMc12VVpQBqsm7natiU/Table-Changes-Wed-7-Apr-2021?node-id=816%3A1266
Cancel (X) button on hover: https://www.figma.com/file/trkiMc12VVpQBqsm7natiU/Table-Changes-Wed-7-Apr-2021?node-id=841%3A1186
@YogeshJayaseelan YogeshJayaseelan added Bug Something isn't working Table Widget Low An issue that is neither critical nor breaks a user flow Needs Triaging Needs attention from maintainers to triage Deploy Preview Issues found in Deploy Preview labels Jul 20, 2021
@github-actions github-actions bot added Widgets Product This label groups issues related to widgets UI Building Pod labels Jul 20, 2021
@YogeshJayaseelan YogeshJayaseelan mentioned this issue Jul 20, 2021
Merged
7 tasks
@somangshu somangshu changed the title [Enhancement] Deploy Preview - Table Widget Filter Pane - To have clear button in the filter pane [Enhancement] Table Widget Filter Pane - clear button to remove all filter Jul 20, 2021
@somangshu somangshu added Needs Design needs design or changes to design and removed Deploy Preview Issues found in Deploy Preview Needs Triaging Needs attention from maintainers to triage labels Jul 20, 2021
@Pranay105 Pranay105 added the Good First Issue Good for newcomers label Sep 22, 2021
@somangshu somangshu removed the Good First Issue Good for newcomers label Oct 4, 2021
@somangshu somangshu removed their assignment Oct 4, 2021
@somangshu
Copy link
Contributor

@momcilo-appsmith need design for clear all filters in the filter pane

@momcilo-appsmith
Copy link

@somangshu Vasanth will be taking this one on.

@momcilo-appsmith
Copy link

@somangshu I added the links to the new designs.

@somangshu
Copy link
Contributor

@momcilo-appsmith please clarify, I see two designs, one with the cross icon and one without, Is there a condition, or it will come with the cross icon always?

@momcilo-appsmith
Copy link

They are actually both with the cancel icon

@somangshu somangshu assigned vibhandikyash and unassigned wmdev0808 Oct 18, 2021
@somangshu somangshu removed the Needs Design needs design or changes to design label Oct 18, 2021
vibhandikyash added a commit that referenced this issue Oct 22, 2021
@vibhandikyash
fix: #5980 added clear all filters button and close filter pane button
6398c7c
@vibhandikyash vibhandikyash mentioned this issue Oct 22, 2021
Merged
7 tasks
vibhandikyash added a commit that referenced this issue Nov 23, 2021
@vibhandikyash
fix: #5980 added clear all filters button and close filter pane button (
75a2592 
#8734)

* fix: #5980 added clear all filters button and close filter pane button

* height updated

* updated class names for test case
@close-label close-label bot added the QA Needs QA attention label Nov 23, 2021
@shwetha-ramesh shwetha-ramesh added Verified When issue is retested post its fixed and removed QA Needs QA attention labels Dec 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vibhandikyash vibhandikyash

Labels
Bug Something isn't working Low An issue that is neither critical nor breaks a user flow Table Widget Verified When issue is retested post its fixed Widgets Product This label groups issues related to widgets
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: #5980 added clear all filters button and close filter pane button appsmithorg/appsmith
8 participants
@Nikhil-Nandagopal @somangshu @vibhandikyash @YogeshJayaseelan @Pranay105 @momcilo-appsmith @wmdev0808 @shwetha-ramesh