Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Task]: Move expires_in field after scope while configuring oauth2 datasource #31059

Open
sneha122 opened this issue Feb 12, 2024 · 15 comments
Open

[Task]: Move expires_in field after scope while configuring oauth2 datasource #31059

sneha122 opened this issue Feb 12, 2024 · 15 comments
Labels
Frontend This label marks the issue or pull request to reference client code Good First Issue Good for newcomers Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Medium Issues that frustrate users due to poor UX Production Query & JS Pod Issues related to the query & JS Pod REST API plugin REST API plugin related issues Task A simple Todo

Comments

@sneha122
Copy link
Contributor

SubTasks

When creating authenticated API datasource for OAuth2, shift expires_in input field just after scope, so that all authentication fields are adjacent to each other, and users can discover it quickly
Screenshot 2024-02-12 at 3 38 29 PM
@sneha122 sneha122 added Good First Issue Good for newcomers Frontend This label marks the issue or pull request to reference client code Task A simple Todo REST API plugin REST API plugin related issues Medium Issues that frustrate users due to poor UX Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. labels Feb 12, 2024
@github-actions github-actions bot added Integrations Product Issues related to a specific integration labels Feb 12, 2024
@yasharma2301
Copy link
Contributor

If this issue has to be worked on, I can take it up

@github-actions github-actions bot added the Query & JS Pod Issues related to the query & JS Pod label Feb 29, 2024
@bandhan-majumder
Copy link

@sneha122 @Nikhil-Nandagopal Hi. I want to ask if this is a rendered HTML page or something else. It may sound stupid, but it's my first time contributing.

@theAravinthM
Copy link

Hi @sneha122
I'm interested to start off my contribution through this issue.
I need one clarification. Is shifting expires_in field alone is okay OR all 2 following fields ( Audience & Resource ) also need to be shifted ?
image

image

@sneha122
Copy link
Contributor Author

sneha122 commented Mar 9, 2024

Hi @yasharma2301 This is a good first issue, you can take it up if you want, Apologies for the delayed response!!

@sneha122
Copy link
Contributor Author

sneha122 commented Mar 9, 2024

Hi @theAravinthM We just need to shift expires_in field after the scope, no need to shift other fields, they can remain as they are today, Hope this helps!

@sneha122
Copy link
Contributor Author

sneha122 commented Mar 9, 2024

Hi @bandhan-majumder The code for this is written in JSX, which is eventually translated to HTML internally by React framework, Hope this answer helps!!

@bandhan-majumder bandhan-majumder mentioned this issue Mar 9, 2024
Closed
theAravinthM added a commit to theAravinthM/appsmith that referenced this issue Mar 17, 2024
@theAravinthM
task: appsmithorg#31059 Move expires_in field after scope while confi…
b7584a2 
…guring oauth2 datasource

Updated RestAPIDatasourceForm.tsx
@theAravinthM theAravinthM mentioned this issue Mar 18, 2024
Closed
@theAravinthM
Copy link

Hi @sneha122 !
Just made a PR - #31863 . Could you please review!

@subhajit20
Copy link

hey @sneha122 is this issue resolved or anyone is already working on it?

@sneha122
Copy link
Contributor Author

sneha122 commented Apr 1, 2024

@subhajit20 Yes there are already PRs created for this

@BOSE-git
Copy link

Hello, is this issue still open?

@sneha122
Copy link
Contributor Author

Hi @BOSE-git There were PRs created for this issue earlier but due to various issues, we could not get around to merging these PRs. Let us discuss this internally and prioritise.

@BOSE-git
Copy link

Should I connect on LinkedIn?

@BOSE-git
Copy link

If there is any issue that I can help with, I will be happy to contribute

@toffee-k21 toffee-k21 mentioned this issue Jul 25, 2024
Closed
@NilanshBansal NilanshBansal self-assigned this Aug 2, 2024
@NilanshBansal
Copy link
Contributor

Moving this to Product Backlog as no response from the contributor

@dakshmehta007 dakshmehta007 mentioned this issue Sep 8, 2024
Closed
@dakshmehta007
Copy link

@sneha122 but there is not any expires_in section available in form file. Are we have to create that by ourself ?

@NilanshBansal NilanshBansal removed their assignment Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Frontend This label marks the issue or pull request to reference client code Good First Issue Good for newcomers Integrations Pod General Issues related to the Integrations Pod that don't fit into other tags. Integrations Product Issues related to a specific integration Medium Issues that frustrate users due to poor UX Production Query & JS Pod Issues related to the query & JS Pod REST API plugin REST API plugin related issues Task A simple Todo
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Shifted position of expires_in fixes #31059
9 participants
@Nikhil-Nandagopal @NilanshBansal @sneha122 @BOSE-git @yasharma2301 @theAravinthM @subhajit20 @bandhan-majumder @dakshmehta007