-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Expires-in in Oauth2 and make Second open source contribution #36174
Move Expires-in in Oauth2 and make Second open source contribution #36174
Conversation
WalkthroughThe pull request introduces new optional configuration options for authentication settings in the GraphQL plugin's JSON file. It adds two fields: "Scope(s)" and "Expires In", which are hidden when the authentication type is set to "oAuth2". The changes restructure the previous definition of the "Scope(s)" field, enhancing the configuration for non-oAuth2 authentication types. Changes
Assessment against linked issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- app/server/appsmith-plugins/graphqlPlugin/src/main/resources/form.json (2 hunks)
Additional comments not posted (2)
app/server/appsmith-plugins/graphqlPlugin/src/main/resources/form.json (2)
121-131
: Well done on adding the "Scope(s)" field.The addition of the "Scope(s)" field enhances the flexibility of the authentication configuration, allowing users to specify scopes in a more granular manner. The implementation of hiding this field when the authentication type is not "oAuth2" is also well thought out, ensuring that it is only visible when relevant.
134-142
: Excellent addition of the "Expires In" field.The "Expires In" field is a thoughtful addition, allowing users to specify the expiration duration of the authentication token. The decision to hide this field when the authentication type is not "oAuth2" ensures that it remains relevant and uncluttered for users not using OAuth2. However, please verify that the placement of this field directly follows the "Scope(s)" field as intended in the PR objectives.
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
This PR has been closed because of inactivity. |
**Title: ** feat: Enhance Authentication Settings with Optional Fields for Scope and Expiration
**Description: **
This PR addresses the issue of making the "Expires-in" part of the form file and solving the related problem. The following changes have been made:
**New Features: **
**Changes: **
**Fixes: ** #31059
**Implementation Details: **
**Updated Form File: **
**Code Adjustments: **
**Testing: **
**Screenshots: **