Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Expires-in in Oauth2 and make Second open source contribution #36174

Conversation

dakshmehta007
Copy link

@dakshmehta007 dakshmehta007 commented Sep 8, 2024

**Title: ** feat: Enhance Authentication Settings with Optional Fields for Scope and Expiration

**Description: **
This PR addresses the issue of making the "Expires-in" part of the form file and solving the related problem. The following changes have been made:

  1. **New Features: **

    • Introduced new optional configuration options for authentication settings in the GraphQL plugin, enhancing flexibility for non-oAuth2 authentication types.
    • Added fields for "Scope(s)" and "Expires In" to allow users to specify scopes and token expiration duration.
  2. **Changes: **

    • Restructured the presentation of the "Scope(s)" field in the configuration to improve usability and clarity.

**Fixes: ** #31059

**Implementation Details: **

  • **Updated Form File: **

    • Added the "Expires In" field to the form file to allow users to set the token expiration duration.
    • Ensured that the "Scope(s)" and "Expires In" fields are hidden when the authentication type is set to "oAuth2".
  • **Code Adjustments: **

    • Modified the relevant components to handle the new fields and their conditions.
    • Updated the logic to ensure the fields are displayed or hidden based on the selected authentication type.

**Testing: **

  • Verified that the new fields appear correctly in the form when applicable.
  • Ensured that the "Scope(s)" and "Expires In" fields are hidden when "oAuth2" is selected.
  • Tested the functionality to confirm that the new fields work as expected and do not introduce any regressions.

**Screenshots: **
image

Copy link
Contributor

coderabbitai bot commented Sep 8, 2024

Walkthrough

The pull request introduces new optional configuration options for authentication settings in the GraphQL plugin's JSON file. It adds two fields: "Scope(s)" and "Expires In", which are hidden when the authentication type is set to "oAuth2". The changes restructure the previous definition of the "Scope(s)" field, enhancing the configuration for non-oAuth2 authentication types.

Changes

Files Change Summary
app/server/appsmith-plugins/graphqlPlugin/src/main/resources/form.json Added optional fields "Scope(s)" and "Expires In" for authentication settings; restructured presentation.

Assessment against linked issues

Objective Addressed Explanation
Move expires_in field after scope while configuring oauth2 datasource (#31059)

In the realm of code where changes flow,
New fields arise, like seeds we sow.
Scope and Expires, a dance they share,
Enhancing the plugin with thoughtful care.
OAuth2 whispers, "Hide me away,"
While flexibility blooms in a bright array! 🌱✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

Commits

Files that changed from the base of the PR and between 58b07dd and e06a089.

Files selected for processing (1)
  • app/server/appsmith-plugins/graphqlPlugin/src/main/resources/form.json (2 hunks)
Additional comments not posted (2)
app/server/appsmith-plugins/graphqlPlugin/src/main/resources/form.json (2)

121-131: Well done on adding the "Scope(s)" field.

The addition of the "Scope(s)" field enhances the flexibility of the authentication configuration, allowing users to specify scopes in a more granular manner. The implementation of hiding this field when the authentication type is not "oAuth2" is also well thought out, ensuring that it is only visible when relevant.


134-142: Excellent addition of the "Expires In" field.

The "Expires In" field is a thoughtful addition, allowing users to specify the expiration duration of the authentication token. The decision to hide this field when the authentication type is not "oAuth2" ensures that it remains relevant and uncluttered for users not using OAuth2. However, please verify that the placement of this field directly follows the "Scope(s)" field as intended in the PR objectives.

Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Sep 15, 2024
Copy link

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant