-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Shifted expires_in field after scope while configuring oauth2 datasource fixes #31059 #31639
Conversation
Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed. |
WalkthroughWalkthroughThis change involves updating the UI layout of the OAuth2 datasource configuration in an application development platform. Specifically, it moves the input field for "Authorization expires in (seconds)" to a new location within the OAuth2 configuration form, placing it immediately after the "scope" field to improve user experience by grouping authentication-related fields together. Changes
Assessment against linked issues
Related issues
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
/build-deploy-preview skip-tests=true |
Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8324759839. |
/ok-to-test tags="@tag.Datasource" |
Whoops! Looks like you're using an outdated method of running the Cypress suite. |
Deploy-Preview-URL: https://ce-31639.dp.appsmith.com |
This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected. |
This PR has been closed because of inactivity. |
Description
[Task]: Move expires_in field after scope while configuring oauth2 datasource #31059
Fixes #
31059
This pull request addresses issue #31059 by reorganizing the layout of the OAuth2 data source configuration. The 'Authorization expires in (seconds)' field, previously positioned way below 'Scope(s)', has been moved to appear right after the 'Scope(s)' field for improved usability and clarity.
Summary by CodeRabbit
Automation
/ok-to-test tags="@tag.Datasource"
🔍 Cypress test results
Caution
If you modify the content in this section, you are likely to disrupt the CI result for your PR.