Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Shifted expires_in field after scope while configuring oauth2 datasource fixes #31059 #31639

Closed
wants to merge 1 commit into from

Conversation

bandhan-majumder
Copy link

@bandhan-majumder bandhan-majumder commented Mar 9, 2024

Description

[Task]: Move expires_in field after scope while configuring oauth2 datasource #31059

Fixes #31059
This pull request addresses issue #31059 by reorganizing the layout of the OAuth2 data source configuration. The 'Authorization expires in (seconds)' field, previously positioned way below 'Scope(s)', has been moved to appear right after the 'Scope(s)' field for improved usability and clarity.

Summary by CodeRabbit

  • Refactor
    • Improved the layout of the form for editing REST API data sources by relocating the "Authorization expires in (seconds)" input field for better user experience.

Automation

/ok-to-test tags="@tag.Datasource"

🔍 Cypress test results

Caution

If you modify the content in this section, you are likely to disrupt the CI result for your PR.

Copy link

welcome bot commented Mar 9, 2024

Welcome to the Appsmith community! Thank you for your first pull request and making this project better. 🤗 Please make sure that you raise a review request so your code change does not go unnoticed.

Copy link
Contributor

coderabbitai bot commented Mar 9, 2024

Walkthrough

Walkthrough

This change involves updating the UI layout of the OAuth2 datasource configuration in an application development platform. Specifically, it moves the input field for "Authorization expires in (seconds)" to a new location within the OAuth2 configuration form, placing it immediately after the "scope" field to improve user experience by grouping authentication-related fields together.

Changes

File Change Summary
.../DataSourceEditor/RestAPIDatasourceForm.tsx Moved the rendering of the "Authorization expires in (seconds)" input field to a new location within the OAuth2 form structure.

Assessment against linked issues

Objective Addressed Explanation
Move expires_in field after scope while configuring oauth2 datasource (#31059)

Related issues

  • [Feature]: Add Supabase as "Saas Integrations" data source #25868: Although this issue focuses on integrating Supabase as a data source and implementing OAuth2 flow for it, the PR does not directly address the objectives related to Supabase integration or the specifics of handling Supabase OAuth2 flows. However, the emphasis on improving OAuth2 configuration could indirectly benefit similar tasks.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@bandhan-majumder bandhan-majumder changed the title Completed task related to issue #31059 Repositioned 'Authorization expires in (seconds)' Field in OAuth2 Datasource Configuration (#31059) Mar 9, 2024
@bandhan-majumder bandhan-majumder changed the title Repositioned 'Authorization expires in (seconds)' Field in OAuth2 Datasource Configuration (#31059) Repositioned Authorization expires in (seconds)' Field in OAuth2 Datasource Configuration (Fixes #31059) Mar 9, 2024
@bandhan-majumder bandhan-majumder changed the title Repositioned Authorization expires in (seconds)' Field in OAuth2 Datasource Configuration (Fixes #31059) Updated OAuth2 Datasource UI: Reposition 'Authorization Expires In (Seconds)' Field ( fixes #31059 ) Mar 9, 2024
@NilanshBansal NilanshBansal requested a review from sneha122 March 10, 2024 09:51
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Mar 17, 2024
@bandhan-majumder bandhan-majumder changed the title Updated OAuth2 Datasource UI: Reposition 'Authorization Expires In (Seconds)' Field ( fixes #31059 ) Updated OAuth2 Datasource UI: Reposition 'Authorization Expires In (Seconds)' Field - fixes #31059 Mar 17, 2024
@sneha122
Copy link
Contributor

/build-deploy-preview skip-tests=true

Copy link

Deploying Your Preview: https://github.com/appsmithorg/appsmith/actions/runs/8324759839.
Workflow: On demand build Docker image and deploy preview.
skip-tests: true.
env: ``.
PR: 31639.
recreate: .

@sneha122
Copy link
Contributor

/ok-to-test tags="@tag.Datasource"

Copy link

Whoops! Looks like you're using an outdated method of running the Cypress suite.
Please check this doc to learn how to correct this!

Copy link

Deploy-Preview-URL: https://ce-31639.dp.appsmith.com

@sneha122 sneha122 changed the title Updated OAuth2 Datasource UI: Reposition 'Authorization Expires In (Seconds)' Field - fixes #31059 fix: Updated OAuth2 Datasource UI: Reposition 'Authorization Expires In (Seconds)' Field - fixes #31059 Mar 18, 2024
@bandhan-majumder bandhan-majumder changed the title fix: Updated OAuth2 Datasource UI: Reposition 'Authorization Expires In (Seconds)' Field - fixes #31059 fix: Shifted expires_in field after scope while configuring oauth2 datasource fixes #31059 Mar 18, 2024
@sneha122 sneha122 added the ok-to-test Required label for CI label Mar 18, 2024
@github-actions github-actions bot removed the Stale label Mar 18, 2024
Copy link

This PR has not seen activitiy for a while. It will be closed in 7 days unless further activity is detected.

@github-actions github-actions bot added the Stale label Mar 28, 2024
@bandhan-majumder bandhan-majumder changed the title fix: Shifted expires_in field after scope while configuring oauth2 datasource fixes #31059 fix: Shifted expires_in field after scope while configuring oauth2 datasource fixes #31059 . Mar 28, 2024
Copy link

github-actions bot commented Apr 5, 2024

This PR has been closed because of inactivity.

@github-actions github-actions bot closed this Apr 5, 2024
@bandhan-majumder bandhan-majumder changed the title fix: Shifted expires_in field after scope while configuring oauth2 datasource fixes #31059 . fix: Shifted expires_in field after scope while configuring oauth2 datasource fixes #31059 Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ok-to-test Required label for CI Stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants