Drop phoenix dependency #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeffkreeftmeijer
force-pushed
the
drop-phoenix-dependency
branch
from
02242e1
to
a985cec
Compare
added 2 commits
January 15, 2017 10:49
This way, we also test compilation of the library when the Phoenix dependency is not available, thus making sure that we guard all Phoenix-specific code with the `Appsignal.phoenix?` test. The test directory itself has also been split in a generic and phoenix-specific directory. Travis CI runs tests on both the `test` and `test_phoenix` environments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Appsignal.phoenix?/0to callCode.ensure_loaded(Phoenix)if Appsignal.phoenix?-blocksif Appsignal.phoenix?-blocksCloses #24.