Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure Travis builds for branches and PRs #67

Merged
merged 1 commit into from
Jan 11, 2017
Merged

Configure Travis builds for branches and PRs #67

merged 1 commit into from
Jan 11, 2017

Conversation

tombruijn
Copy link
Member

@tombruijn tombruijn commented Jan 11, 2017

Only build master and develop branches when pushed. When a PR is made on GitHub travis will start a build as well.

This change prevents two builds being started for one change, like you can see in PR #61 under "All checks have passed - 2 successful checks".

This PR only triggers one build as you can see below.

Scenario

Steps to reproduce issue

  • I push a branch to make a PR (a build is triggered on TravisCI)
  • I make a PR on the repo (a build is triggered on TravisCI)

expected result

  • one build triggered

actual result

  • two builds triggered

New setup

  • build branches "master" and "develop" on push
  • build PRs when created.
  • other branches are ignored on push

Note

This is the same behavior we have on the Ruby gem repo: appsignal/appsignal-ruby#131

Only build master and develop branches when pushed. When a PR is made on
GitHub travis will start a build as well.
@arjan arjan merged commit f139277 into master Jan 11, 2017
@tombruijn tombruijn deleted the travis branch January 11, 2017 20:22
jeffkreeftmeijer pushed a commit that referenced this pull request Jan 12, 2017
Only build master and develop branches when pushed. When a PR is made on
GitHub travis will start a build as well.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants