Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop phoenix dependency #61

Merged
merged 7 commits into from
Jan 16, 2017
Merged

Drop phoenix dependency #61

merged 7 commits into from
Jan 16, 2017

Commits on Jan 11, 2017

  1. Make phoenix dependency optional

    @jeffkreeftmeijer
    jeffkreeftmeijer committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    5b61f07 View commit details
    Browse the repository at this point in the history

  2. Wrap Phoenix modules in Code.ensure_loaded?(Phoenix) blocks

    @jeffkreeftmeijer
    jeffkreeftmeijer committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    02f1c67 View commit details
    Browse the repository at this point in the history

  3. Ensure Plug.Conn is loaded before defining Helpers.instrument with a … 

    …%Plug.Conn{}
    @jeffkreeftmeijer
    jeffkreeftmeijer committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    1e5f68c View commit details
    Browse the repository at this point in the history

  4. Make sure Phoenix and Plug are loaded before defining functions that … 

    …use them
    @jeffkreeftmeijer
    jeffkreeftmeijer committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    02ae3d0 View commit details
    Browse the repository at this point in the history

  5. Add Appsignal.phoenix?/0

    @jeffkreeftmeijer
    jeffkreeftmeijer committed Jan 11, 2017
    Configuration menu
    Copy the full SHA
    a985cec View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2017

  1. Add 'test_phoenix' Mix env 

    This way, we also test compilation of the library when the Phoenix
dependency is not available, thus making sure that we guard all
Phoenix-specific code with the `Appsignal.phoenix?` test.

The test directory itself has also been split in a generic and
phoenix-specific directory.

Travis CI runs tests on both the `test` and `test_phoenix` environments.
    Arjan Scherpenisse committed Jan 15, 2017
    Configuration menu
    Copy the full SHA
    59d872b View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into drop-phoenix-dependency

    Arjan Scherpenisse committed Jan 15, 2017
    Configuration menu
    Copy the full SHA
    b0010a3 View commit details
    Browse the repository at this point in the history