Skip to content

Conversation

@simonjbeaumont
Copy link
Contributor

Motivation:

As described in #2016, there are many tests in NIOPosixTests for types that have since moved from NIOPosix to NIOCore.

Modifications:

Move the tests from NIOPosixTests that do not import NIOPosix into NIOCoreTests

Result:

Tests for types defined in the NIOCore module are more likely to be located in NIOCoreTests test target.

Resolves #2016.

@Lukasa Lukasa added the semver/none No version bump required. label May 4, 2022
Copy link
Contributor

@Lukasa Lukasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, solid change.

@Lukasa
Copy link
Contributor

Lukasa commented May 4, 2022

You've got a few CI failures to fix.

@simonjbeaumont
Copy link
Contributor Author

You've got a few CI failures to fix.

20:53:16 [196/272] Compiling NIOCoreTests LinuxTest+XCTest.swift
20:53:16 /code/Tests/NIOCoreTests/LinuxTest.swift:33:13: error: cannot find 'withTemporaryFile' in scope
20:53:16             withTemporaryFile(content: quota) { (_, quotaPath) -> Void in

... LinuxTest. Makes sense why this passed locally :) Will fix.

Signed-off-by: Si Beaumont <beaumont@apple.com>
@Lukasa
Copy link
Contributor

Lukasa commented May 4, 2022

Looks like some helper functions are missing.

Signed-off-by: Si Beaumont <beaumont@apple.com>
Signed-off-by: Si Beaumont <beaumont@apple.com>
@simonjbeaumont
Copy link
Contributor Author

@Lukasa I think this is all resolved now. The 5.7 and nightly pipelines are failing with some allocation counts. Presumably that's not related.

@Lukasa
Copy link
Contributor

Lukasa commented May 4, 2022

Seems unlikely, yeah.

Signed-off-by: Si Beaumont <beaumont@apple.com>
@Lukasa Lukasa enabled auto-merge (squash) May 4, 2022 14:56
@Lukasa Lukasa merged commit cd11cf8 into apple:main May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

semver/none No version bump required.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split NIOPosix tests up

2 participants