-
Notifications
You must be signed in to change notification settings - Fork 719
Move tests of NIOCore types from NIOPosixTests to NIOCoreTests #2093
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Lukasa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice one, solid change.
|
You've got a few CI failures to fix. |
... |
Signed-off-by: Si Beaumont <beaumont@apple.com>
45db2b6 to
83ef20f
Compare
|
Looks like some helper functions are missing. |
Signed-off-by: Si Beaumont <beaumont@apple.com>
4b20868 to
f358af3
Compare
Signed-off-by: Si Beaumont <beaumont@apple.com>
f358af3 to
c9eaf99
Compare
|
@Lukasa I think this is all resolved now. The 5.7 and nightly pipelines are failing with some allocation counts. Presumably that's not related. |
|
Seems unlikely, yeah. |
Signed-off-by: Si Beaumont <beaumont@apple.com>
Motivation:
As described in #2016, there are many tests in
NIOPosixTestsfor types that have since moved fromNIOPosixtoNIOCore.Modifications:
Move the tests from
NIOPosixTeststhat do notimport NIOPosixintoNIOCoreTestsResult:
Tests for types defined in the
NIOCoremodule are more likely to be located inNIOCoreTeststest target.Resolves #2016.