fixup: No swift-system, duh

Signed-off-by: Si Beaumont <beaumont@apple.com>

Author: simonjbeaumont

Tests/NIOCoreTests/LinuxTest.swift

@@ -18,7 +18,7 @@ import XCTest
 class LinuxTest: XCTestCase {
     func testCoreCountQuota() {
         #if os(Linux) || os(Android)
-        [
+        try [
             ("50000", "100000", 1),
             ("100000", "100000", 1),
             ("100000\n", "100000", 1),
@@ -31,8 +31,8 @@ class LinuxTest: XCTestCase {
             ("100000", "", nil),
             ("100000", "0", nil)
         ].forEach { quota, period, count in
-            withTemporaryFile(content: quota) { (_, quotaPath) -> Void in
-                withTemporaryFile(content: period) { (_, periodPath) -> Void in
+            try withTemporaryFile(content: quota) { (_, quotaPath) -> Void in
+                try withTemporaryFile(content: period) { (_, periodPath) -> Void in
                     XCTAssertEqual(Linux.coreCount(quota: quotaPath, period: periodPath), count)
                 }
             }
@@ -42,7 +42,7 @@ class LinuxTest: XCTestCase {
 
     func testCoreCountCpuset() {
         #if os(Linux) || os(Android)
-        [
+        try [
             ("0", 1),
             ("0,3", 2),
             ("0-3", 4),
@@ -51,7 +51,7 @@ class LinuxTest: XCTestCase {
             ("0,2-4,6,7,9-11", 9),
             ("", nil)
         ].forEach { cpuset, count in
-            withTemporaryFile(content: cpuset) { (_, path) -> Void in
+            try withTemporaryFile(content: cpuset) { (_, path) -> Void in
                 XCTAssertEqual(Linux.coreCount(cpuset: path), count)
             }
         }

Tests/NIOCoreTests/XCTest+Extensions.swift

@@ -14,7 +14,6 @@
 
 import XCTest
 import NIOCore
-import struct System.FileDescriptor
 
 func assert(_ condition: @autoclosure () -> Bool, within time: TimeAmount, testInterval: TimeAmount? = nil, _ message: String = "condition not satisfied in time", file: StaticString = #file, line: UInt = #line) {
     let testInterval = testInterval ?? TimeAmount.nanoseconds(time.nanoseconds / 5)
@@ -44,18 +43,18 @@ func assertNoThrowWithValue<T>(_ body: @autoclosure () throws -> T, defaultValue
 }
 
 func withTemporaryFile<T>(content: String? = nil, _ body: (NIOCore.NIOFileHandle, String) throws -> T) throws -> T {
-    let (fd, path) = openTemporaryFile()
-    let fileHandle = NIOFileHandle(descriptor: fd)
+    let temporaryFilePath = "\(temporaryDirectory)/nio_\(UUID())"
+    FileManager.default.createFile(atPath: temporaryFilePath, contents: content?.data(using: .utf8))
     defer {
-        XCTAssertNoThrow(try fileHandle.close())
-        XCTAssertEqual(0, unlink(path))
+        XCTAssertNoThrow(try FileManager.default.removeItem(atPath: temporaryFilePath))
     }
-    if let content = content {
-        let fileDesciptor = FileDescriptor(rawValue: fd)
-        try fileDesciptor.writeAll(content.utf8)
-        XCTAssertEqual(try fileDesciptor.seek(offset: 0, from: .start), 0)
+
+    let fileHandle = try NIOFileHandle(path: temporaryFilePath, mode: .write)
+    defer {
+        XCTAssertNoThrow(try fileHandle.close())
     }
-    return try body(fileHandle, path)
+
+    return try body(fileHandle, temporaryFilePath)
 }
 
 fileprivate var temporaryDirectory: String {
@@ -77,16 +76,3 @@ fileprivate var temporaryDirectory: String {
 #endif // targetEnvironment
     }
 }
-
-func openTemporaryFile() -> (CInt, String) {
-    let template = "\(temporaryDirectory)/nio_XXXXXX"
-    var templateBytes = template.utf8 + [0]
-    let templateBytesCount = templateBytes.count
-    let fd = templateBytes.withUnsafeMutableBufferPointer { ptr in
-        ptr.baseAddress!.withMemoryRebound(to: Int8.self, capacity: templateBytesCount) { (ptr: UnsafeMutablePointer<Int8>) in
-            return mkstemp(ptr)
-        }
-    }
-    templateBytes.removeLast()
-    return (fd, String(decoding: templateBytes, as: Unicode.UTF8.self))
-}