Skip to content

Throw 400 status erro when a non numeric value is encountered on page… #1872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Throw 400 status erro when a non numeric value is encountered on page… #1872

wants to merge 2 commits into from

Conversation

Mathieudewet
Copy link
Contributor

… request attribute in pagination

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #1860
License MIT
Doc PR

@Mathieudewet Mathieudewet force-pushed the fix/pagination-non-numeric-value branch from 56a2656 to 8ecdb70 Compare April 16, 2018 10:15
@IonBazan
Copy link
Contributor

IonBazan commented Apr 16, 2018 •
edited
Loading

@Mathieudewet please check #1872. We should merge both solutions to add page >= 1 validation.
Edit: I meant #1871

meyerbaptiste
meyerbaptiste requested changes Apr 16, 2018
View reviewed changes
Copy link
Member

@meyerbaptiste meyerbaptiste left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO #1871 is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@meyerbaptiste meyerbaptiste meyerbaptiste requested changes

@IonBazan IonBazan IonBazan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mathieudewet @IonBazan @meyerbaptiste