Page number int casting #1871
Merged
Page number int casting #1871
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meyerbaptiste
approved these changes
Apr 16, 2018
|
Can you change the base branch? Bugfixes should target the |
|
@meyerbaptiste done 😃 |
|
Is it a problem with the rebase because I see some "totalCount" stuff which is not related to this bug? Edit: Yeah, you screwed up the rebase... 😆 |
|
Something like this should do it: git reset --hard upstream/2.2
git cherry-pick 25c831e |
|
@teohhanhui I merged |
|
thanks @IonBazan |
teohhanhui
pushed a commit
to teohhanhui/api-platform-core
that referenced
this pull request
May 2, 2018
Page number int casting
This was referenced May 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds casting
page[page]parameter tointand page number validation. It throws an error when page number is less than 1 and tries to convert a string to int when possible.