Throw 400 status erro when a non numeric value is encountered on page request attribute in pagination

Author: Mathieudewet

features/jsonapi/pagination.feature

@@ -32,3 +32,10 @@ Feature: JSON API pagination handling
     And the JSON node "meta.totalItems" should be equal to the number 10
     And the JSON node "meta.itemsPerPage" should be equal to the number 15
     And the JSON node "meta.currentPage" should be equal to the number 1
+
+  Scenario: Get a paginated collection with an non numeric page request attribute
+    When I send a "GET" request to "/dummies?page[page]=dummie_non_numeric"
+    Then the response should be in JSON
+    And the response status code should be 400
+    And the JSON node title should be equal to 'An error occurred'
+    And the JSON node description should be equal to 'Page request attribute must be a numeric value'

src/Bridge/Doctrine/Orm/Extension/PaginationExtension.php

@@ -25,6 +25,7 @@
 use Doctrine\ORM\Tools\Pagination\Paginator as DoctrineOrmPaginator;
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\RequestStack;
+use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
 
 /**
  * Applies pagination on the Doctrine query for resource collection when enabled.
@@ -262,6 +263,10 @@ private function useOutputWalkers(QueryBuilder $queryBuilder): bool
     private function getPaginationParameter(Request $request, string $parameterName, $default = null)
     {
         if (null !== $paginationAttribute = $request->attributes->get('_api_pagination')) {
+            if (isset($paginationAttribute['page']) && !is_numeric($paginationAttribute['page'])) {
+                throw new BadRequestHttpException('Page request attribute must be a numeric value');
+            }
+
             return array_key_exists($parameterName, $paginationAttribute) ? $paginationAttribute[$parameterName] : $default;
         }