Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix redirect from bad find/replace #12642

Merged
merged 1 commit into from
Jan 21, 2021

Conversation

mistercrunch
Copy link
Member

@mistercrunch mistercrunch commented Jan 21, 2021

#12289 did a find/replace across the board to remove all reference to the incubator/incubation/incubating and sent the Apache server's .htaccess file into a infinite redirect loop. This fixes that.

Tested in production here apache/superset-site@b22c82d

@request-info
Copy link

request-info bot commented Jan 21, 2021

We would appreciate it if you could provide us with more info about this issue/pr! Please do not leave the title or description empty.

@request-info request-info bot added the need:more-info Requires more information from author label Jan 21, 2021
@codecov-io
Copy link

codecov-io commented Jan 21, 2021

Codecov Report

Merging #12642 (9296e76) into master (e7def7e) will decrease coverage by 0.30%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12642      +/-   ##
==========================================
- Coverage   66.80%   66.49%   -0.31%     
==========================================
  Files        1017     1017              
  Lines       49730    49730              
  Branches     4864     4864              
==========================================
- Hits        33221    33067     -154     
- Misses      16386    16540     +154     
  Partials      123      123              
Flag Coverage Δ
cypress 50.97% <ø> (ø)
javascript 60.79% <ø> (ø)
python 63.47% <ø> (-0.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.72%) ⬇️
superset/db_engine_specs/hive.py 54.61% <0.00%> (-29.24%) ⬇️
superset/db_engine_specs/presto.py 70.56% <0.00%> (-10.83%) ⬇️
superset/views/database/mixins.py 80.70% <0.00%> (-1.76%) ⬇️
superset/models/core.py 88.04% <0.00%> (-0.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7def7e...9296e76. Read the comment docs.

Copy link
Member

@robdiciuccio robdiciuccio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find!

@mistercrunch mistercrunch merged commit 06a80cd into apache:master Jan 21, 2021
@mistercrunch mistercrunch deleted the fix_docs_redirect branch January 21, 2021 04:25
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.2.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels need:more-info Requires more information from author preset-io size/XS 🚢 1.2.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants