-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove harmless incubator refs #12289
chore: remove harmless incubator refs #12289
Conversation
Codecov Report
@@ Coverage Diff @@
## master #12289 +/- ##
==========================================
- Coverage 67.17% 66.99% -0.19%
==========================================
Files 1002 1002
Lines 49231 49282 +51
Branches 5000 5003 +3
==========================================
- Hits 33073 33017 -56
- Misses 16035 16141 +106
- Partials 123 124 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing this! I did my best to verify that the changes are valid, and looks valid throughout. I wouldn't be surprised if something has gone unnoticed/broken, but in that case we can fix with a follow-up PR.
Btw, there's a linting error that needs to be fixed, other than that LGTM.
SUMMARY
resolves #12286
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TEST PLAN
ADDITIONAL INFORMATION