Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove harmless incubator refs #12289

Merged
merged 5 commits into from
Jan 6, 2021

Conversation

amitmiran137
Copy link
Member

SUMMARY

resolves #12286

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TEST PLAN

ADDITIONAL INFORMATION

  • Has associated issue:
  • Changes UI
  • Requires DB Migration.
  • Confirm DB Migration upgrade and downgrade tested.
  • Introduces new feature or API
  • Removes existing feature or API

@codecov-io
Copy link

codecov-io commented Jan 5, 2021

Codecov Report

Merging #12289 (5426a31) into master (d4a854e) will decrease coverage by 0.18%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #12289      +/-   ##
==========================================
- Coverage   67.17%   66.99%   -0.19%     
==========================================
  Files        1002     1002              
  Lines       49231    49282      +51     
  Branches     5000     5003       +3     
==========================================
- Hits        33073    33017      -56     
- Misses      16035    16141     +106     
- Partials      123      124       +1     
Flag Coverage Δ
cypress 51.39% <ø> (-0.01%) ⬇️
javascript 61.22% <ø> (-0.04%) ⬇️
python 63.92% <ø> (-0.29%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/Button/Button.stories.jsx 82.35% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 87.62% <ø> (ø)
superset-frontend/src/utils/downloadAsImage.ts 33.33% <ø> (ø)
superset/config.py 90.54% <ø> (ø)
superset/models/alerts.py 96.00% <ø> (ø)
superset/models/core.py 87.77% <ø> (-1.09%) ⬇️
superset/tasks/alerts/observer.py 100.00% <ø> (ø)
superset/tasks/schedules.py 76.36% <ø> (ø)
superset/utils/celery.py 96.42% <ø> (-3.58%) ⬇️
superset/utils/core.py 89.80% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 673dea7...5426a31. Read the comment docs.

@ktmud ktmud changed the title Chore/remove harmless incubator refs chore: remove harmless incubator refs Jan 6, 2021
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I did my best to verify that the changes are valid, and looks valid throughout. I wouldn't be surprised if something has gone unnoticed/broken, but in that case we can fix with a follow-up PR.

Btw, there's a linting error that needs to be fixed, other than that LGTM.

@villebro villebro merged commit b221417 into apache:master Jan 6, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0 labels Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 1.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

GitHub repo move - rewire all reference from apache/incubator-superset to apache/superset
5 participants