Skip to content

Commit

Permalink
fix: missing key when verifying adhoc filters in merge_extra_filters (#…
Browse files Browse the repository at this point in the history
…12620)

Co-authored-by: Bryan Keller <bkeller@netflix.com>
  • Loading branch information
bryanck and Bryan Keller authored Jan 20, 2021
1 parent b592165 commit e7def7e
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions superset/utils/core.py
Original file line number Diff line number Diff line change
Expand Up @@ -1025,8 +1025,8 @@ def get_filter_key(f: Dict[str, Any]) -> str:
for existing in adhoc_filters:
if (
existing["expressionType"] == "SIMPLE"
and existing["comparator"] is not None
and existing["subject"] is not None
and existing.get("comparator") is not None
and existing.get("subject") is not None
):
existing_filters[get_filter_key(existing)] = existing["comparator"]

Expand Down

0 comments on commit e7def7e

Please sign in to comment.