[SPARK-37886][PYTHON][TESTS] Use ComparisonTestBase in pandas test #35183
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
FYI @xinrong-databricks @HyukjinKwon |
HyukjinKwon
approved these changes
Jan 14, 2022
HyukjinKwon
changed the title
Member
Author
|
FYI #35203, the Ops related tests have some refactors, so I also make it in a separated PR to help easy review. |
Member
|
👌 |
Member
|
Merged to master. |
dchvn
pushed a commit
to dchvn/spark
that referenced
this pull request
Jan 19, 2022
### What changes were proposed in this pull request? Use `ComparisonTestBase` as base class instead of `PandasOnSparkTestCase` with self.psdf in pandas test https://github.com/apache/spark/blob/a70006d9a7b578721d152d0f89d1a894de38c25d/python/pyspark/testing/pandasutils.py#L265-L272 ### Why are the changes needed? We have many testcase are using same logic to covert `pdf` to `psdf`, we can use ComparisonTestBase as base class to reduce redundant. ### Does this PR introduce _any_ user-facing change? NO, test only ### How was this patch tested? UT passed. Closes apache#35183 from Yikun/SPARK-37886. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Use
ComparisonTestBaseas base class instead ofPandasOnSparkTestCasewith self.psdf in pandas testspark/python/pyspark/testing/pandasutils.py
Lines 265 to 272 in a70006d
Why are the changes needed?
We have many testcase are using same logic to covert
pdftopsdf, we can use ComparisonTestBase as base class to reduce redundant.Does this PR introduce any user-facing change?
NO, test only
How was this patch tested?
UT passed.