Skip to content

Conversation

@HyukjinKwon
Copy link
Member

@HyukjinKwon HyukjinKwon commented Jan 12, 2022

What changes were proposed in this pull request?

This PR proposes to show the link of Check run view instead of Actions view. Previously, when you add a new custom Check, e.g., test_report.yml, Actions view also showed this Check.

Now, seems GitHub Actions changed the behaviour - Actions view always includes the jobs initiated by the specific Workflow e.g., build_and_test.yml does not include the custom Check added from test_report.yml.

To work around this problem, this PR proposes to show the link of:
Check run view e.g., https://github.com/apache/spark/runs/4785069876 ("Report test results" is included) instead of
Actions view e.g., https://github.com/apache/spark/actions/runs/1686013487 ("Report test results" is missing) .

After this PR, when developers click the link here:

Screen Shot 2022-01-12 at 10 07 26 PM

it will open a Check run view instead of Actions view which does not have test report tab.

Why are the changes needed?

For developers to see the test report, and they can easily detect which test is failed.

Does this PR introduce any user-facing change?

No, dev-only

How was this patch tested?

Manually tested at HyukjinKwon#51.

@github-actions github-actions bot added the INFRA label Jan 12, 2022
@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 12, 2022

@Yikun
Copy link
Member

Yikun commented Jan 12, 2022

I have roughly know the purpose of this PR, looks good. One question, is it necessary to link to "Report test results" directly instead of "Configure Jobs"? That is https://github.com/apache/spark/runs/4785827549 in your example.

(BTW, I didn't even realize we had this test report before. 😂)

Copy link
Member

@dongjoon-hyun dongjoon-hyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, LGTM. Thank you, @HyukjinKwon and all.
Merged to master.

@HyukjinKwon
Copy link
Member Author

HyukjinKwon commented Jan 12, 2022

Thanks @dongjoon-hyun and @Yikun!

One question, is it necessary to link to "Report test results" directly instead of "Configure Jobs"? That is https://github.com/apache/spark/runs/4785827549 in your example.

Yeah, I thought about this but the problem is that when the jobs are in a queue (triggered but not started yet), it only has two states Configure jobs and Check changes. So, the job cannot be linked until Report test results appears but this is the end of tests that could take few hours ..

@Yikun
Copy link
Member

Yikun commented Jan 13, 2022

@HyukjinKwon Looks like update_build_status job is worked unexpectly after this PR. Such as this PR: #35183, it is stucked in "queued" status.

I also took a look on update job, it raised 404 in update_build_status job, it was wrong to get the run_id on https://api.github.com/repos/Yikun/spark/actions/runs/4797718278, but the right api should be https://api.github.com/repos/Yikun/spark/actions/runs/1690601631.

There are 2 potential workaround make update_build_status work I guess:

Workaround 1, still return the old runID in here:

Workaround 2, Get right action id according new runID

run = await github.request('GET /repos/{owner}/{repo}/actions/runs/{run_id}', params)

@HyukjinKwon
Copy link
Member Author

oh yeah. I think we can fix it with workaround 2.

HyukjinKwon pushed a commit that referenced this pull request Jan 13, 2022
…_build_status.yml

### What changes were proposed in this pull request?
Change actions to check-runs in update_build_status.yml.

### Why are the changes needed?
#35179 (comment)

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

Closes #35189 from Yikun/patch-11.

Authored-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon
Copy link
Member Author

Fixed in #35189. Let's see how it goes. Thanks @Yikun!

@Yikun
Copy link
Member

Yikun commented Jan 13, 2022

New PR: #35193

HyukjinKwon added a commit that referenced this pull request Jan 13, 2022
### What changes were proposed in this pull request?

This PR is a retry of #35179. This PR does the same thing - replacing Actions view to Check run view for `See test results` link.

The main difference with the PR #35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark:

https://github.com/apache/spark/blob/85efc85f9aa93b3fac9e591c96efa38d4414adf8/.github/workflows/update_build_status.yml#L63-L74

Now this PR shouldn't affect [update_build_status.yml](https://github.com/apache/spark/blob/master/.github/workflows/update_build_status.yml) which was the main reason of a followup and revert.

### Why are the changes needed?

For developers to see the test report, and they can easily detect which test is failed.

### Does this PR introduce _any_ user-facing change?

No, dev-only

### How was this patch tested?

Tested in HyukjinKwon#51.

Closes #35193 from HyukjinKwon/SPARK-37879-retry.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dchvn pushed a commit to dchvn/spark that referenced this pull request Jan 19, 2022
### What changes were proposed in this pull request?

This PR proposes to show the link of Check run view instead of Actions view. Previously, when you add a new custom Check, e.g., [test_report.yml](https://github.com/apache/spark/blob/master/.github/workflows/test_report.yml), Actions view also showed this Check.

Now, seems GitHub Actions changed the behaviour - Actions view always includes the jobs initiated by the specific Workflow e.g., [build_and_test.yml](https://github.com/apache/spark/blob/master/.github/workflows/build_and_test.yml) does not include the custom Check added from [test_report.yml](https://github.com/apache/spark/blob/master/.github/workflows/test_report.yml).

To work around this problem, this PR proposes to show the link of:
Check run view e.g., https://github.com/apache/spark/runs/4785069876 ("Report test results" is included) instead of
Actions view e.g., https://github.com/apache/spark/actions/runs/1686013487 ("Report test results" is missing) .

After this PR, when developers click the link here:

![Screen Shot 2022-01-12 at 10 07 26 PM](https://user-images.githubusercontent.com/6477701/149146026-80f3ac26-ba06-411f-9cb8-f5395ffd8432.png)

it will open a Check run view instead of Actions view which does not have test report tab.

### Why are the changes needed?

For developers to see the test report, and they can easily detect which test is failed.

### Does this PR introduce _any_ user-facing change?

No, dev-only

### How was this patch tested?

Manually tested at HyukjinKwon#51.

Closes apache#35179 from HyukjinKwon/show-test-report.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
dchvn pushed a commit to dchvn/spark that referenced this pull request Jan 19, 2022
…_build_status.yml

### What changes were proposed in this pull request?
Change actions to check-runs in update_build_status.yml.

### Why are the changes needed?
apache#35179 (comment)

### Does this PR introduce _any_ user-facing change?
No

### How was this patch tested?

Closes apache#35189 from Yikun/patch-11.

Authored-by: Yikun Jiang <yikunkero@gmail.com>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
dchvn pushed a commit to dchvn/spark that referenced this pull request Jan 19, 2022
### What changes were proposed in this pull request?

This PR is a retry of apache#35179. This PR does the same thing - replacing Actions view to Check run view for `See test results` link.

The main difference with the PR apache#35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark:

https://github.com/apache/spark/blob/85efc85f9aa93b3fac9e591c96efa38d4414adf8/.github/workflows/update_build_status.yml#L63-L74

Now this PR shouldn't affect [update_build_status.yml](https://github.com/apache/spark/blob/master/.github/workflows/update_build_status.yml) which was the main reason of a followup and revert.

### Why are the changes needed?

For developers to see the test report, and they can easily detect which test is failed.

### Does this PR introduce _any_ user-facing change?

No, dev-only

### How was this patch tested?

Tested in HyukjinKwon#51.

Closes apache#35193 from HyukjinKwon/SPARK-37879-retry.

Authored-by: Hyukjin Kwon <gurwls223@apache.org>
Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
@HyukjinKwon HyukjinKwon deleted the show-test-report branch January 15, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants