-
Notifications
You must be signed in to change notification settings - Fork 29k
[SPARK-37879][INFRA] Show test report in GitHub Actions builds from PRs #35179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
I have roughly know the purpose of this PR, looks good. One question, is it necessary to link to "Report test results" directly instead of "Configure Jobs"? That is https://github.com/apache/spark/runs/4785827549 in your example. (BTW, I didn't even realize we had this test report before. 😂) |
dongjoon-hyun
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, LGTM. Thank you, @HyukjinKwon and all.
Merged to master.
|
Thanks @dongjoon-hyun and @Yikun!
Yeah, I thought about this but the problem is that when the jobs are in a queue (triggered but not started yet), it only has two states |
|
@HyukjinKwon Looks like update_build_status job is worked unexpectly after this PR. Such as this PR: #35183, it is stucked in "queued" status. I also took a look on update job, it raised 404 in update_build_status job, it was wrong to get the run_id on https://api.github.com/repos/Yikun/spark/actions/runs/4797718278, but the right api should be https://api.github.com/repos/Yikun/spark/actions/runs/1690601631. There are 2 potential workaround make update_build_status work I guess: Workaround 1, still return the old runID in here:
Workaround 2, Get right action id according new runID
|
|
oh yeah. I think we can fix it with workaround 2. |
…_build_status.yml ### What changes were proposed in this pull request? Change actions to check-runs in update_build_status.yml. ### Why are the changes needed? #35179 (comment) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Closes #35189 from Yikun/patch-11. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
|
New PR: #35193 |
### What changes were proposed in this pull request? This PR is a retry of #35179. This PR does the same thing - replacing Actions view to Check run view for `See test results` link. The main difference with the PR #35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark: https://github.com/apache/spark/blob/85efc85f9aa93b3fac9e591c96efa38d4414adf8/.github/workflows/update_build_status.yml#L63-L74 Now this PR shouldn't affect [update_build_status.yml](https://github.com/apache/spark/blob/master/.github/workflows/update_build_status.yml) which was the main reason of a followup and revert. ### Why are the changes needed? For developers to see the test report, and they can easily detect which test is failed. ### Does this PR introduce _any_ user-facing change? No, dev-only ### How was this patch tested? Tested in HyukjinKwon#51. Closes #35193 from HyukjinKwon/SPARK-37879-retry. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
### What changes were proposed in this pull request? This PR proposes to show the link of Check run view instead of Actions view. Previously, when you add a new custom Check, e.g., [test_report.yml](https://github.com/apache/spark/blob/master/.github/workflows/test_report.yml), Actions view also showed this Check. Now, seems GitHub Actions changed the behaviour - Actions view always includes the jobs initiated by the specific Workflow e.g., [build_and_test.yml](https://github.com/apache/spark/blob/master/.github/workflows/build_and_test.yml) does not include the custom Check added from [test_report.yml](https://github.com/apache/spark/blob/master/.github/workflows/test_report.yml). To work around this problem, this PR proposes to show the link of: Check run view e.g., https://github.com/apache/spark/runs/4785069876 ("Report test results" is included) instead of Actions view e.g., https://github.com/apache/spark/actions/runs/1686013487 ("Report test results" is missing) . After this PR, when developers click the link here:  it will open a Check run view instead of Actions view which does not have test report tab. ### Why are the changes needed? For developers to see the test report, and they can easily detect which test is failed. ### Does this PR introduce _any_ user-facing change? No, dev-only ### How was this patch tested? Manually tested at HyukjinKwon#51. Closes apache#35179 from HyukjinKwon/show-test-report. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
…_build_status.yml ### What changes were proposed in this pull request? Change actions to check-runs in update_build_status.yml. ### Why are the changes needed? apache#35179 (comment) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? Closes apache#35189 from Yikun/patch-11. Authored-by: Yikun Jiang <yikunkero@gmail.com> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
### What changes were proposed in this pull request? This PR is a retry of apache#35179. This PR does the same thing - replacing Actions view to Check run view for `See test results` link. The main difference with the PR apache#35179 is that we now keep the Actions run id as is as metadata so this Actions run id can be used to update the status of tests in PRs at Apache Spark: https://github.com/apache/spark/blob/85efc85f9aa93b3fac9e591c96efa38d4414adf8/.github/workflows/update_build_status.yml#L63-L74 Now this PR shouldn't affect [update_build_status.yml](https://github.com/apache/spark/blob/master/.github/workflows/update_build_status.yml) which was the main reason of a followup and revert. ### Why are the changes needed? For developers to see the test report, and they can easily detect which test is failed. ### Does this PR introduce _any_ user-facing change? No, dev-only ### How was this patch tested? Tested in HyukjinKwon#51. Closes apache#35193 from HyukjinKwon/SPARK-37879-retry. Authored-by: Hyukjin Kwon <gurwls223@apache.org> Signed-off-by: Hyukjin Kwon <gurwls223@apache.org>
What changes were proposed in this pull request?
This PR proposes to show the link of Check run view instead of Actions view. Previously, when you add a new custom Check, e.g., test_report.yml, Actions view also showed this Check.
Now, seems GitHub Actions changed the behaviour - Actions view always includes the jobs initiated by the specific Workflow e.g., build_and_test.yml does not include the custom Check added from test_report.yml.
To work around this problem, this PR proposes to show the link of:
Check run view e.g., https://github.com/apache/spark/runs/4785069876 ("Report test results" is included) instead of
Actions view e.g., https://github.com/apache/spark/actions/runs/1686013487 ("Report test results" is missing) .
After this PR, when developers click the link here:
it will open a Check run view instead of Actions view which does not have test report tab.
Why are the changes needed?
For developers to see the test report, and they can easily detect which test is failed.
Does this PR introduce any user-facing change?
No, dev-only
How was this patch tested?
Manually tested at HyukjinKwon#51.