[SPARK-37886][PYTHON][TESTS] Use ComparisonTestBase as base class in OpsTestBase #35203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itholic
approved these changes
Jan 17, 2022
Contributor
itholic
left a comment
itholic
left a comment
There was a problem hiding this comment.
One comment, but not a strong opinion, otherwise it seems fine to me
Yikun
changed the title
Contributor
|
LGTM. |
Member
Author
|
cc @HyukjinKwon @xinrong-databricks |
Member
|
Merged to master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
ComparisonTestBase(PandasOnSparkTestCasewithpdfandpsdf)*OpsTestinherited fromOpsTestBaseWhy are the changes needed?
All data type ops related tests case are using
PandasOnSparkTestCase, TestCasesUtilsas basic classes, we'd better just letTestCasesUtilsinherited fromPandasOnSparkTestCaseinstead of multiple inheritance.Does this PR introduce any user-facing change?
No
How was this patch tested?
UT