ORC-867: Upgrade hive-storage-api to 2.8.1#773
ORC-867: Upgrade hive-storage-api to 2.8.1#773dongjoon-hyun merged 1 commit intoapache:mainfrom dongjoon-hyun:ORC-867
Conversation
|
cc @williamhyun and @pavibhai |
kbendick
left a comment
kbendick
left a comment
There was a problem hiding this comment.
This is great. Thank you @dongjoon-hyun!
Is there anything we can change / remove from the build (pom) file? I took a look, and it didn't seem like it as the only explicit dependency is on the commons-lang3, but felt worth bringing up just in case.
|
Thank you for review and approval, @kbendick . |
|
Oh.. |
| return null; | ||
| } | ||
|
|
||
| @Override |
There was a problem hiding this comment.
Looks like we will do another release of StorageAPI. I was wondering if we should push this as a default?
There was a problem hiding this comment.
Yes, we need 2.8.1. This PR will stay here and will retarget to 2.8.1, @pavibhai .
BTW, what do you mean by the following?
we should push this as a default?
There was a problem hiding this comment.
I was wondering if we should add a default implementation to this new method into PredicateLeaf. But not required if this is the only failure we are seeing.
|
Since apache/hive#2543 is merged, we will retry when |
dongjoon-hyun
changed the title
omalley
left a comment
omalley
left a comment
There was a problem hiding this comment.
LGTM, other than the pom needs to switch to storage-api 2.8.1. Build & unit tests run fine.
|
Thank you, @omalley . I also saw that 2.8.1 is published already. The pom is updated and I rebased this PR. |
|
If CIs pass, I'll merge this to main/branch-1.7. |
|
All Java test passed with GitHub Action (Java8/11/16/17-ea). |
4 participants
What changes were proposed in this pull request?
This PR aims to upgrade
hive-storage-apifrom 2.7.2 to 2.8.1.Why are the changes needed?
This will bring the latest improvement and bug fixes.
How was this patch tested?
Pass the CIs.