HIVE-25386: hive-storage-api should not have guava compile dependency#2531
Closed
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:HIVE-25386
Closed
HIVE-25386: hive-storage-api should not have guava compile dependency#2531dongjoon-hyun wants to merge 1 commit intoapache:masterfrom dongjoon-hyun:HIVE-25386
dongjoon-hyun wants to merge 1 commit intoapache:masterfrom
dongjoon-hyun:HIVE-25386
Conversation
Member
Author
|
cc @belugabehr and @miklosgergely from #1784 which introduced this regression. |
dongjoon-hyun
commented
Jul 26, 2021
| <groupId>com.google.guava</groupId> | ||
| <artifactId>guava</artifactId> | ||
| <version>${guava.version}</version> | ||
| <scope>test</scope> |
Member
Author
There was a problem hiding this comment.
This was removed in the following commit without the reason of removal. I hope this recovers the dependency without breaking CIs.
If some CI fails, it means the regression already spread to the other modules.
pgaref
reviewed
Jul 26, 2021
Contributor
pgaref
left a comment
pgaref
left a comment
There was a problem hiding this comment.
Thanks for digging this up @dongjoon-hyun !
I am keeping an eye on this and the test results
pgaref
approved these changes
Jul 26, 2021
Contributor
pgaref
left a comment
pgaref
left a comment
There was a problem hiding this comment.
Tests passed, change LGTM
omalley
pushed a commit
that referenced
this pull request
Jul 26, 2021
Fixes #2531 Signed-off-by: Owen O'Malley <omalley@apache.org>
Member
Author
zchovan
pushed a commit
to zchovan/hive
that referenced
this pull request
Jul 29, 2021
Fixes apache#2531 Signed-off-by: Owen O'Malley <omalley@apache.org>
dengzhhu653
pushed a commit
to dengzhhu653/hive
that referenced
this pull request
Dec 15, 2022
Fixes apache#2531 Signed-off-by: Owen O'Malley <omalley@apache.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR aims to fix the recent regression of HIVE-24542 at
hive-storage-api2.8.0 release.Why are the changes needed?
HIVE-13906 removed the compile dependency on Guava at Apache Hive 2.2.0.
So, the downstream like Apache ORC can use it cleanly. We should recover this regression.
Does this PR introduce any user-facing change?
Yes, this is a bug fix for the dependency change.
How was this patch tested?
Pass the CIs.