Skip to content

ORC-867: Upgrade hive-storage-api to 2.8.1 #773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dongjoon-hyun merged 1 commit into from
Aug 4, 2021
Merged

ORC-867: Upgrade hive-storage-api to 2.8.1 #773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions java/core/src/test/org/apache/orc/impl/TestRecordReaderImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -310,6 +310,9 @@ public Object getLiteral() {
return null;
}

@Override
Copy link
Contributor

@pavibhai pavibhai Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we will do another release of StorageAPI. I was wondering if we should push this as a default?

Copy link
Member Author

@dongjoon-hyun dongjoon-hyun Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, we need 2.8.1. This PR will stay here and will retarget to 2.8.1, @pavibhai .

BTW, what do you mean by the following?

we should push this as a default?

Copy link
Contributor

@pavibhai pavibhai Jul 26, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering if we should add a default implementation to this new method into PredicateLeaf. But not required if this is the only failure we are seeing.

public int getId() { return -1; }

@Override
public List<Object> getLiteralList() {
return null;
Expand Down
2 changes: 1 addition & 1 deletion java/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@
<min.hadoop.version>2.2.0</min.hadoop.version>
<hadoop.version>2.7.3</hadoop.version>
<tools.hadoop.version>2.10.1</tools.hadoop.version>
<storage-api.version>2.7.2</storage-api.version>
<storage-api.version>2.8.1</storage-api.version>
<zookeeper.version>3.7.0</zookeeper.version>
<maven.version>3.6.3</maven.version>
<maven-assembly-plugin.version>3.3.0</maven-assembly-plugin.version>
Expand Down