feature: full support for states in the refactored state machine designer #6169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
December 18, 2023 17:15
ptyin
force-pushed
the
refactor/designer
branch
from
85f59ea
to
0f033d2
Compare
wt-better
reviewed
Jan 4, 2024
| @@ -60,12 +60,12 @@ export function setProperties(businessObject, properties, override) { | |||
| export function is(element, target) { | |||
| const type = element?.businessObject?.Type || element?.Type || element; | |||
|
|
|||
| if (target === 'State') { | |||
| return type === 'ServiceTask'; | |||
| if (target === 'Task') { | |||
There was a problem hiding this comment.
this modification is expect?
There was a problem hiding this comment.
Yes. This function is to check the type for an element. For now, I need to know if an element is a ‘Task’ or not, not if it is a 'State'.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Full support for states in the refactored Saga state machine designer
Ⅱ. Does this pull request fix one issue?
fixes #6129