Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support old version state machine designer artifacts #6137

Open
ptyin opened this issue Dec 11, 2023 · 4 comments
Open

Support old version state machine designer artifacts #6137

ptyin opened this issue Dec 11, 2023 · 4 comments
Assignees
Labels
good first issue Good for newcomers task: help-wanted Extra attention is needed

Comments

@ptyin
Copy link
Member

ptyin commented Dec 11, 2023

Why you need it?

New version state machine designer uses JSON with style information that is great similar to the user-written JSON. However, the JSON file that old version (i.e., the one implemented in GGEditor) is in a very different form. The new version should be backward-compatible.

How it could be?

Extend SagaImporter to be backward-compatible.

Other related information

Please merge related PR to the refactor_designer branch.

@ptyin ptyin added task: help-wanted Extra attention is needed good first issue Good for newcomers labels Dec 11, 2023
@elysium-w
Copy link

@ptyin I would like to work on this issue. Could you please assign it to me?

@ptyin
Copy link
Member Author

ptyin commented May 28, 2024

@ptyin I would like to work on this issue. Could you please assign it to me?

Sure. You can first shed some lights on it (how would you like to design and test), and then work on implementation.

@elysium-w
Copy link

@ptyin I would like to work on this issue. Could you please assign it to me?

Sure. You can first shed some lights on it (how would you like to design and test), and then work on implementation.

My idea might be simpler. Add a converter function that checks whether the JSON is in the old version format. If so, convert it to the new version format.
And I want to know,how many versions before?Which version of Seata uses the old JSON format?

@ptyin
Copy link
Member Author

ptyin commented Jun 11, 2024

@ptyin I would like to work on this issue. Could you please assign it to me?

Sure. You can first shed some lights on it (how would you like to design and test), and then work on implementation.

My idea might be simpler. Add a converter function that checks whether the JSON is in the old version format. If so, convert it to the new version format. And I want to know,how many versions before?Which version of Seata uses the old JSON format?

There is a breaking change on the designer introduced by the following PR,

The old JSON format indicates the one before this PR. So what you should concern about is the one. You can checkout the 2.0.0 branch to see the older version,

https://github.com/apache/incubator-seata/tree/2.0.0/saga/seata-saga-statemachine-designer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers task: help-wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants