REST: Fallback to older logic for existence check in RESTSessionCatalog #12294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
changed the title
ebyhr
force-pushed
the
ebi/rest-fallback
branch
2 times, most recently
from
7e60357 to
2b70a24
Compare
ebyhr
force-pushed
the
ebi/rest-fallback
branch
from
2b70a24 to
b7810f3
Compare
|
@ebyhr just FYI that this was already proposed in #12259 (comment) |
This was referenced Feb 17, 2025
snazy
reviewed
Feb 17, 2025
| try { | ||
| checkIdentifierIsValid(identifier); | ||
| client.head(paths.table(identifier), headers(context), ErrorHandlers.tableErrorHandler()); | ||
| return true; | ||
| if (endpoints.contains(Endpoint.V1_TABLE_EXISTS)) { |
There was a problem hiding this comment.
Not an issue of this PR, but I doubt that there is any Iceberg-REST-service implementation that does not implement the HEAD endpoint - simply because versions up to 1.7 did not fail.
I'd propose to replace the V1_TABLE/VIEW/NAMESPACE_EXISTS with V1_LOAD_TABLE/VIEW/NAMESPACE to revert to the pre-1.8 behavior.
|
Closing as #12314 was merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PRs have prevented Trino from upgrading to Iceberg 1.8.0: